Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider method get_provisioning_trace #54

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

timidri
Copy link

@timidri timidri commented Sep 19, 2023

Adds a method to generate a JSON description of the vsphere events. This is now only added to this provider, so it's not a required provider method at this time.

Fixes #55

Depends on puppetlabs/vmpooler#629

@timidri timidri requested a review from a team as a code owner September 19, 2023 11:30
@yachub yachub added the enhancement New feature or request label Dec 14, 2023
Copy link

@yachub yachub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I really like the data coming from this. I wonder if we can convert that json object to a bit prettier output, like without the escape characters and newlines? That way we can copy the entire content of the event list after "vm provisioning trace:" and easily pipe it through jq or something to make it easier to read the events.

Also might be nice to include the common log prefix used in other places, like [!] [debian-12-x86_64] 'spicy-proton' vm provisioning trace: []

@yachub
Copy link

yachub commented Jan 23, 2024

Thanks for the contribution, I really like the data coming from this. I wonder if we can convert that json object to a bit prettier output, like without the escape characters and newlines? That way we can copy the entire content of the event list after "vm provisioning trace:" and easily pipe it through jq or something to make it easier to read the events.

Also might be nice to include the common log prefix used in other places, like [!] [debian-12-x86_64] 'spicy-proton' vm provisioning trace: []

The above could also be done in another iteration, so up to ya'll!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make vmpooler query and log status information from VCenter during waiting for a VM
3 participants