-
Notifications
You must be signed in to change notification settings - Fork 59
Add okapilib 5.1.0 for kernel 4.2.1 #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to consider recompiling 5.1.0 on the newest PROS version and test it a little... I think 5.1.0 was compiled on a beta PROS 4 version. Don't want to put something out that we can't commit to supporting and debugging.
It is compiled for the latest kernel (4.2.1). We've sent it to some users to test it for us. |
if the uploaded binary is compiled for the latest Kernel, then OkapiLib should probably be updated with a new minor version (5.1.1) with the bump. Need to differentiate between the base release version and the newer version. |
The latest released version is 5.0.0 for kernel 4.0.3. This pr is the next release so I set the version as 5.1.0. I don't see why it should be 5.1.1 if 5.1.0 hasn't been released yet. |
Ah I thought the latest was 5.1.0 before this version, in that case you'd probably want to push to the Okapi lib repo a 5.0.1 tag instead and make this release 5.0.1 . Seems like that repo doesn't have tagged releases set up yet. Means that if SIGBots ever decides to set up an Okapilib dev group more major releases can take 5.1.0 and it'd be a little more clear what 5.1.0 would mean. |
We marked some functions as deprecated in this release so if we're following semver we need to increment the minor version. I'll merge to master and push a tag on the okapilib repo once testing is done. |
Untested but it compiles ig