Remove turn-on-purescript-font-lock and turn-off-purescript-font-lock #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions provide no useful cases because font-locking is enabled by default and can be disabled by turning off font-lock (which the "turn-off" function is a wrapper over). At the same time, the function constitutes huge chunk of the code and comes up while trying to figure where things are called from. Basically, the functions are just duplicating the functional, and I'm hoping they have no users. Turns out also, the function removal was attempted in 0a9580d, however… I am not exactly sure what went wrong but the author only posted the NEWS entry about the functions being removed, but made no chages regarding them.
Hi-Angel
force-pushed
the
more-tests3
branch
from
da1e8e4 to
117a660
Compare
Hi-Angel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions provide no useful cases because font-locking is enabled
by default and can be disabled by turning off font-lock (which the
"turn-off" function is a wrapper over). At the same time, the function
constitutes huge chunk of the code and comes up while trying to figure
where things are called from.
Basically, the functions are just duplicating the functional, and I'm
hoping they have no users.
Turns out also, the function removal was attempted in 0a9580d,
however… I am not exactly sure what went wrong but the author only
posted the NEWS entry about the functions being removed, but made no
chages regarding them.