Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flake and lockfile, add spago and purs-backend-es to shell #1104

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Update flake and lockfile, add spago and purs-backend-es to shell #1104

merged 2 commits into from
Oct 23, 2023

Conversation

thomashoneyman
Copy link
Member

@thomashoneyman thomashoneyman commented Oct 23, 2023 •
edited
Loading

Description of the change

This minor internal-only update does a couple things:

  1. Updates the flake to the latest purescript-overlay (giving access to spago 0.93.18, among other things)
  2. Adds spago to the dev shell. Spago is used in the package.json scripts but we don't actually specify a version anywhere; now, the latest spago from purescript-overlay will be used.
  3. Adds purs-backend-es to the dev shell. Right now the optimizer isn't used, but I've added it so it's easy to integrate into e.g. the publish workflow at some time; it provides noticeable speed improvements so it would be nice to publish an optimized spago.
  4. Updates the spago.lock file. Something must be funky about the lockfile generation, as this was out-of-date regarding the updated ordered-collections version from a few days ago.

thomashoneyman
thomashoneyman commented Oct 23, 2023
View reviewed changes
flake.nix
# TODO: we need to get purescript-overlay to track the latest versions
# spago-unstable
purs-tidy-bin.purs-tidy-0_10_0
purs
Copy link
Member Author

@thomashoneyman thomashoneyman Oct 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will provide the latest stable. Right now that's 0.15.12.

f-f
f-f approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And yes, lockfiles are broken until we fix #917 😄

@f-f f-f merged commit 5e56348 into master Oct 23, 2023
@f-f f-f deleted the trh/misc-updates branch October 23, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-f f-f f-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomashoneyman @f-f