Trimming the prefix_by message while censoring warning

[imsaravana369]

One of the ways to censor warnings is by using by_prefix. Some warning messages have additional leading whitespaces so the filtering is not happening correctly, so this PR fixes this by doing the filtering after trimming the text.

TODO

Checklist:

• Added the change to the "Unreleased" section of the changelog
• Added some example of the new feature to the README
• Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

[imsaravana369]

Should we give support for regex also?

[f-f]

I'm not sure what this is addressing - do you have a concrete example?

[imsaravana369]

So I have this in my spago.yaml

    censor_project_warnings:
        - by_prefix: "The Name"

and the warning message i want to handle is,

Name a1 was introduced but not used.
  in value declaration main

but the issue is somehow the warning message is padded with leading whitespace, so I had to change by_prefix in such a way it has the leading whitespace(matching the error message).

[f-f]

Ah that makes sense!
I don't think we should support regexes as of now.

Could you add a test for this?

[imsaravana369]

yes sure will add tests

[imsaravana369]

Added testcase

[f-f]

A few notes:

• if you move the fixture files into a directory that is structures as a spago project, then you can use FS.copyTree to just copy the project in the test directory, so you don't have to call init and do this file juggling. See the fixtures for the monorepo tests for an example
• the test is not checking that things are properly censored, just asserting that the build succeeds. We should check that we are not getting these warnings - see this test in the monorepo suite that is doing a similar thing:

spago/test/Spago/Build/Monorepo.purs

Lines 124 to 135 in fdaa7e6

	Spec.it "build succeeds when 'strict: true' because warnings were censored" \{ spago, fixture } -> do
	FS.copyTree { src: fixture "monorepo/strict-true-censored-warnings", dst: "." }
	let
	paths =
	[ escapePathInErrMsg [ "package-a", "src", "Main.purs:6:13" ]
	, escapePathInErrMsg [ "package-b", "src", "Main.purs:6:13" ]
	, escapePathInErrMsg [ "package-c", "src", "Main.purs:6:13" ]
	]
	shouldNotHaveWarning stdErr = do
	when (Array.any (\exp -> String.contains (Pattern exp) stdErr) paths) do
	Assert.fail $ "STDERR contained one or more texts:\n" <> show paths <> "\n\nStderr was:\n" <> stdErr
	spago [ "build" ] >>= check { stdout: mempty, stderr: shouldNotHaveWarning, result: isRight }

[imsaravana369]

okay this one looks neat, will do this👍

[imsaravana369]

Made the changes in the test cases, can you check once?

[f-f]

Thanks!