Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ptime mapper script #737

Draft
wants to merge 81 commits into
base: master
Choose a base branch
from
Draft

Ptime mapper script #737

wants to merge 81 commits into from

Conversation

RandomTannenbaum
Copy link
Collaborator

No description provided.

This was linked to issues Jun 24, 2024
Write ID Mapper-Script | PuzzleTime Sync #2 #735
Open
Create delayed job | PuzzleTime Sync #3 #734
Open
@ManuelMoeri ManuelMoeri requested a review from mtnstar July 1, 2024 06:52
@ManuelMoeri ManuelMoeri requested review from Robin481 and removed request for mtnstar July 11, 2024 11:25
@ManuelMoeri ManuelMoeri assigned Robin481 and unassigned mtnstar Jul 11, 2024
Robin481
Robin481 requested changes Jul 12, 2024
View reviewed changes
Gemfile.lock Show resolved Hide resolved
app/domain/ptime/assign_employee_ids.rb Outdated Show resolved Hide resolved
app/domain/ptime/assign_employee_ids.rb Outdated Show resolved Hide resolved
app/domain/ptime/assign_employee_ids.rb Outdated Show resolved Hide resolved
app/domain/ptime/assign_employee_ids.rb Outdated Show resolved Hide resolved
app/domain/ptime/assign_employee_ids.rb Outdated Show resolved Hide resolved
app/domain/ptime/assign_employee_ids.rb Outdated Show resolved Hide resolved
app/domain/ptime/client.rb Outdated Show resolved Hide resolved
app/domain/ptime/client.rb Outdated Show resolved Hide resolved
config/application.rb Outdated Show resolved Hide resolved
@kcinay055679 kcinay055679 force-pushed the ptime-mapper-script branch from a2d0349 to 2763d61 Compare July 29, 2024 13:04
RandomTannenbaum and others added 20 commits February 6, 2025 09:10
@RandomTannenbaum @ManuelMoeri
Create migration to add ptime id to person model
f1cd221
@RandomTannenbaum @ManuelMoeri
Start writing mapper script
761976d
@ManuelMoeri
Implement basic PTime client class and install webmock gem
4a9e94e
@ManuelMoeri
Create new migration to fix naming of ptime_emplyoee_id attribute
735c43b
@ManuelMoeri
Add first test to see how webmock works
082208f
@RandomTannenbaum @ManuelMoeri
Fix first client spec
3c6a167
@RandomTannenbaum @ManuelMoeri
Write json body to test employee endpoint
655e213
@RandomTannenbaum @ManuelMoeri
Fix tests by allowing localhost connection and write negative test fo…
395caa7 
…r the ptime client
@RandomTannenbaum @ManuelMoeri
Make ptime client specs not read values from env variables
48106d2
@RandomTannenbaum @ManuelMoeri
Set error messages on errors in client and change test data urls to e…
0b29267 
…xample.com
@RandomTannenbaum @ManuelMoeri
Fix params of ptime client and implement basic mapper script
47cafc9
@RandomTannenbaum @ManuelMoeri
Add new tests and remove unnecessary
bdc8dcd
@ManuelMoeri
Add test for ambiguous matched people
8427400
@ManuelMoeri
Add email to filter before matching as well
eb315c2
@ManuelMoeri
Possibly make rubocop happy
bfeb831
@ManuelMoeri
Try to make rubocop happy again
84cb2f4
@RandomTannenbaum @ManuelMoeri
Add evaluate task for mapping script
56b987d
@RandomTannenbaum @ManuelMoeri
Outsource mapper script code to methods and fix tests
d40d602
@RandomTannenbaum @ManuelMoeri
Add test for dry run
3585dd7
@RandomTannenbaum @ManuelMoeri
Make rubocop happy :)
97a4aab
ManuelMoeri and others added 27 commits February 6, 2025 10:10
@ManuelMoeri
Fix test and add comment
8b888ea
@ManuelMoeri
Generalize window resizing of capybara
c8742fd
@ManuelMoeri
Cleanup code and add comments
66bcfaa
@ManuelMoeri
Add one more test for client.rb
9652b3d
@ManuelMoeri
Reverse test from last commit
4667f5b
@kcinay055679 @ManuelMoeri
change location of helper
30ce8ae
@kcinay055679 @ManuelMoeri
set ptime stubing global
7e52d67
@kcinay055679 @ManuelMoeri
clean up ptime client specs
8d4c205
@kcinay055679 @ManuelMoeri
create json file for fixtures
05f3719
@kcinay055679 @ManuelMoeri
use hashes instead of strings for json keys create global ptime stub …
24d83a1 
…method
@kcinay055679 @ManuelMoeri
use custom ptime stubbing method everywhere
4723653
@kcinay055679 @ManuelMoeri
fix tests after always using [:data]
6c9d2f1
@kcinay055679 @ManuelMoeri
clean up ptime client
2271215
@kcinay055679 @ManuelMoeri
improve structure of people search
f97fb2a
@kcinay055679 @ManuelMoeri
Client isn't longer controlled by random env vars
ab0407f
@kcinay055679 @ManuelMoeri
simplify ptime_helpers
a5ca9bd
@kcinay055679 @ManuelMoeri
clean up PR
8fe5033
@kcinay055679 @ManuelMoeri
Clean up Skills db fallback logic
149e40f
@kcinay055679 @ManuelMoeri
improve readability by using more helper
212d595
@kcinay055679 @ManuelMoeri
clean up
5f71113
@kcinay055679 @ManuelMoeri
add client test
e0b4941
@kcinay055679 @ManuelMoeri
ds muäs so
9221a77
@kcinay055679 @ManuelMoeri
so its aber
480ebd0
@RandomTannenbaum @ManuelMoeri
Resolve conversations
8e2ca7e
@RandomTannenbaum @ManuelMoeri
Remove unneeded spec and fix spec that tests the not found case when …
a207a11 
…mapping
@RandomTannenbaum @ManuelMoeri
Fix order of name interpolation in id mapper script
95ce74d
@RandomTannenbaum @ManuelMoeri
Update json fixtures and use full_name instead of interpolating it
9c7eef9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robin481 Robin481 Robin481 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Robin481 Robin481

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write ID Mapper-Script | PuzzleTime Sync #2 Create delayed job | PuzzleTime Sync #3
5 participants
@RandomTannenbaum @Robin481 @mtnstar @ManuelMoeri @kcinay055679