Code

Ptime mapper script#737

Code

Draft

RandomTannenbaum wants to merge 81 commits intomasterpuzzle/skills:masterfrom ptime-mapper-scriptpuzzle/skills:ptime-mapper-scriptCopy head branch name to clipboard

+812-161

Commits

Commits on Feb 6, 2025

• Create migration to add ptime id to person model

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  f1cd221

  Copy full SHA for f1cd221

• Start writing mapper script

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  761976d

  Copy full SHA for 761976d

• Implement basic PTime client class and install webmock gem

  ManuelMoeri

  committed
  4a9e94e

  Copy full SHA for 4a9e94e

• Create new migration to fix naming of ptime_emplyoee_id attribute

  ManuelMoeri

  committed
  735c43b

  Copy full SHA for 735c43b

• Add first test to see how webmock works

  ManuelMoeri

  committed
  082208f

  Copy full SHA for 082208f

• Fix first client spec

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  3c6a167

  Copy full SHA for 3c6a167

• Write json body to test employee endpoint

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  655e213

  Copy full SHA for 655e213

• Fix tests by allowing localhost connection and write negative test for the ptime client

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  395caa7

  Copy full SHA for 395caa7

• Make ptime client specs not read values from env variables

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  48106d2

  Copy full SHA for 48106d2

• Set error messages on errors in client and change test data urls to example.com

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  0b29267

  Copy full SHA for 0b29267

• Fix params of ptime client and implement basic mapper script

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  47cafc9

  Copy full SHA for 47cafc9

• Add new tests and remove unnecessary

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  bdc8dcd

  Copy full SHA for bdc8dcd

• Add test for ambiguous matched people

  ManuelMoeri

  committed
  8427400

  Copy full SHA for 8427400

• Add email to filter before matching as well

  ManuelMoeri

  committed
  eb315c2

  Copy full SHA for eb315c2

• Possibly make rubocop happy

  ManuelMoeri

  committed
  bfeb831

  Copy full SHA for bfeb831

• Try to make rubocop happy again

  ManuelMoeri

  committed
  84cb2f4

  Copy full SHA for 84cb2f4

• Add evaluate task for mapping script

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  56b987d

  Copy full SHA for 56b987d

• Outsource mapper script code to methods and fix tests

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  d40d602

  Copy full SHA for d40d602

• Add test for dry run

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  3585dd7

  Copy full SHA for 3585dd7

• Make rubocop happy :)

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  97a4aab

  Copy full SHA for 97a4aab

• Remove unnecessary requires

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  867b146

  Copy full SHA for 867b146

• Replace .count == 1 with .one?

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  dcd239c

  Copy full SHA for dcd239c

• Start writing script that updates the data of the people in skills

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  eb0d907

  Copy full SHA for eb0d907

• Write script that maps the data from a ptime employee to the corresponding skills person

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  a8bca9c

  Copy full SHA for a8bca9c

• Disable rubocop metrics all together instead of one by one in assign employee id and update people data scripts

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  419e926

  Copy full SHA for 419e926

• Fix file naming of spec files

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  cf7dab0

  Copy full SHA for cf7dab0

• Move class into module and fix mapping of person to employee data, write specs to test mapping of people data

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  b10e47e

  Copy full SHA for b10e47e

• Fix updating of people data and test it and fix faulty key in json used for testing requests

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  2c90e91

  Copy full SHA for 2c90e91

• Fix update people data specs by assigning the ptime base url env var in before each

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  67413ad

  Copy full SHA for 67413ad

• Only update ptime employee id if its not already set

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  895f10f

  Copy full SHA for 895f10f

• Test if marital status can be changed in specs

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  a818493

  Copy full SHA for a818493

• Write rake task that runs the people update

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  9274d82

  Copy full SHA for 9274d82

• Show message in assign employee ids script conditionally

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  769fcfc

  Copy full SHA for 769fcfc

• Add delayed jobs and daemon gems and start writing delayed jobs

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  5016ccd

  Copy full SHA for 5016ccd

• Fix specs to work with delayed job

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  21cb63e

  Copy full SHA for 21cb63e

• Remove delayed job functionality

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  f363c85

  Copy full SHA for f363c85

• Add first approach for fetching people from ptime API

  ManuelMoeri

  committed
  eabfb17

  Copy full SHA for eabfb17

• Add helper and write test for fetching employee data

  ManuelMoeri

  committed
  be4d4aa

  Copy full SHA for be4d4aa

• Finish test and fix logic in displaying people

  ManuelMoeri

  committed
  3705c50

  Copy full SHA for 3705c50

• Implement correct routing of person and fix a problem in the docker setup with yminder

  ManuelMoeri

  committed
  2104041

  Copy full SHA for 2104041

• Possibly fix docker compose file

  ManuelMoeri

  committed
  3e8f1a9

  Copy full SHA for 3e8f1a9

• Fix tests and implement logic for sorting people

  ManuelMoeri

  committed
  42603a6

  Copy full SHA for 42603a6

• Implement logic for fallback and cleanup helper method

  ManuelMoeri

  committed
  ee5fb57

  Copy full SHA for ee5fb57

• Improve fallback logic by making it more readable and shorter

  ManuelMoeri

  committed
  689e43d

  Copy full SHA for 689e43d

• Implement first approach on calling the ptime api after 5 minutes

  ManuelMoeri

  committed
  b1ccac8

  Copy full SHA for b1ccac8

• Improve logic of 5 minutes request and change client.rb

  ManuelMoeri

  committed
  c05b374

  Copy full SHA for c05b374

• Add logic to load site correctly and remove unnecessary code

  ManuelMoeri

  committed
  b4af35d

  Copy full SHA for b4af35d

• Fix logic of rendering people and cleanup code

  ManuelMoeri

  committed
  3df1c04

  Copy full SHA for 3df1c04

• Add tests for person_helper

  ManuelMoeri

  committed
  5d30c49

  Copy full SHA for 5d30c49

• Add ptime_helpers to cleanup code

  ManuelMoeri

  committed
  3a9a0b8

  Copy full SHA for 3a9a0b8

• Fix tests

  ManuelMoeri

  committed
  2465292

  Copy full SHA for 2465292

• Fix last test and remove pry

  ManuelMoeri

  committed
  ba6dd04

  Copy full SHA for ba6dd04

• Fix test and add comment

  ManuelMoeri

  committed
  8b888ea

  Copy full SHA for 8b888ea

• Generalize window resizing of capybara

  ManuelMoeri

  committed
  c8742fd

  Copy full SHA for c8742fd

• Cleanup code and add comments

  ManuelMoeri

  committed
  66bcfaa

  Copy full SHA for 66bcfaa

• Add one more test for client.rb

  ManuelMoeri

  committed
  9652b3d

  Copy full SHA for 9652b3d

• Reverse test from last commit

  ManuelMoeri

  committed
  4667f5b

  Copy full SHA for 4667f5b

• change location of helper

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  30ce8ae

  Copy full SHA for 30ce8ae

• set ptime stubing global

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  7e52d67

  Copy full SHA for 7e52d67

• clean up ptime client specs

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  8d4c205

  Copy full SHA for 8d4c205

• create json file for fixtures

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  05f3719

  Copy full SHA for 05f3719

• use hashes instead of strings for json keys create global ptime stub method

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  24d83a1

  Copy full SHA for 24d83a1

• use custom ptime stubbing method everywhere

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  4723653

  Copy full SHA for 4723653

• fix tests after always using [:data]

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  6c9d2f1

  Copy full SHA for 6c9d2f1

• clean up ptime client

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  2271215

  Copy full SHA for 2271215

• improve structure of people search

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  f97fb2a

  Copy full SHA for f97fb2a

• Client isn't longer controlled by random env vars

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  ab0407f

  Copy full SHA for ab0407f

• simplify ptime_helpers

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  a5ca9bd

  Copy full SHA for a5ca9bd

• clean up PR

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  8fe5033

  Copy full SHA for 8fe5033

• Clean up Skills db fallback logic

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  149e40f

  Copy full SHA for 149e40f

• improve readability by using more helper

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  212d595

  Copy full SHA for 212d595

• clean up

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  5f71113

  Copy full SHA for 5f71113

• add client test

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  e0b4941

  Copy full SHA for e0b4941

• ds muäs so

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  9221a77

  Copy full SHA for 9221a77

• so its aber

  

  kcinay055679

  authored and

  ManuelMoeri

  committed
  480ebd0

  Copy full SHA for 480ebd0

• Resolve conversations

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  8e2ca7e

  Copy full SHA for 8e2ca7e

• Remove unneeded spec and fix spec that tests the not found case when mapping

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  a207a11

  Copy full SHA for a207a11

• Fix order of name interpolation in id mapper script

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  95ce74d

  Copy full SHA for 95ce74d

• Update json fixtures and use full_name instead of interpolating it

  

  RandomTannenbaum

  authored and

  ManuelMoeri

  committed
  9c7eef9

  Copy full SHA for 9c7eef9

• Fix the docker compose

  ManuelMoeri

  committed
  ba01610

  Copy full SHA for ba01610

• Fix a helper method and fix naming to actually call the right one

  ManuelMoeri

  committed
  a409596

  Copy full SHA for a409596