Merge main to staging #4671
Merged
Merge main to staging #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com> Co-authored-by: Migush <Migushthe2nd@users.noreply.github.com> Co-authored-by: Abdullhakim Sami Alshanqity <132011567+abdullhakim-sami@users.noreply.github.com> Co-authored-by: mecmep <69386369+mecmep@users.noreply.github.com>
…#4656) Currently, the "Start new PWA" flow results in the following error on macOS, because PWABuilder tries to create a path using Windows backslash separators. ```A system error occurred (ENOENT: no such file or directory, rename '/REDACTED\decompressedTemplate\pwa-starter-main' -> '/REDACTED\REDACTED')``` ## PR Type Bugfix Co-authored-by: Justin Willis <jgw9617@gmail.com>
|
Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
jgw96
added a commit
that referenced
this pull request
Mar 4, 2024
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com> Co-authored-by: Migush <Migushthe2nd@users.noreply.github.com> Co-authored-by: Abdullhakim Sami Alshanqity <132011567+abdullhakim-sami@users.noreply.github.com> Co-authored-by: mecmep <69386369+mecmep@users.noreply.github.com> Co-authored-by: Joel Limberg <me@joellimberg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #[issue number]
PR Type
Describe the current behavior?
Describe the new behavior?
PR Checklist
npm run testand ensure that all tests passAdditional Information