Skip to content

Conversation

@Leonabcd123
Copy link
Contributor

@Leonabcd123 Leonabcd123 commented Oct 24, 2025

Fixes #970

Remove /dojos from the start of the url
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

{% macro render_dojo_link(data) %}
{% if data.dojo_name %}
<a href="/dojos/{{ data.dojo_id }}">{{ data.dojo_name }}</a>
{% elif data.dojo_id %}
<a href="/dojos/{{ data.dojo_id }}">{{ data.dojo_id }}</a>

P1 Badge Update render_dojo_link to match new dojo routes

The commit removes the /dojos prefix in render_dojo_module_challenge, reflecting that dojo pages are served by @dojo.route("/<dojo>"). However, render_dojo_link still emits URLs of the form /dojos/{id}. Feed entries that use this macro (emoji awards and dojo updates) will continue linking to a non-existent path and 404, so the fix only applies to a subset of events. render_dojo_link should build URLs like /<dojo_id> to match the updated routing.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Leonabcd123
Copy link
Contributor Author

Why do we even have this part of the code twice?

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Leonabcd123 Leonabcd123 changed the title Fix links to dojos in feed page fix: Fix links to dojos in feed page Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links to dojos in feed page don't work

1 participant