Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated feature.py module from GCM #1070

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

bloebp
Copy link
Member

@bloebp bloebp commented Nov 10, 2023

These methods are now available in the feature_relevance.py module.

@bloebp bloebp requested a review from petergtz November 10, 2023 00:15
@bloebp bloebp force-pushed the remove_experimental_disclaimer branch from 033c47b to 3d515ea Compare November 10, 2023 00:22
@bloebp bloebp force-pushed the remove_feature_module branch from e380f74 to 379c12c Compare November 10, 2023 00:23
@bloebp bloebp force-pushed the remove_experimental_disclaimer branch from 3d515ea to 05108ba Compare November 10, 2023 07:22
@bloebp bloebp force-pushed the remove_feature_module branch from 379c12c to 18e140d Compare November 10, 2023 07:22
petergtz
petergtz previously approved these changes Nov 10, 2023
@bloebp bloebp force-pushed the remove_experimental_disclaimer branch from 05108ba to c2e707c Compare November 15, 2023 15:28
@bloebp bloebp changed the base branch from remove_experimental_disclaimer to main November 15, 2023 21:17
@bloebp bloebp dismissed petergtz’s stale review November 15, 2023 21:17

The base branch was changed.

These methods are now available in the feature_relevance.py module.

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
@bloebp bloebp force-pushed the remove_feature_module branch from 18e140d to 6966dc0 Compare November 16, 2023 14:39
@bloebp bloebp merged commit 601c2ae into main Nov 17, 2023
30 checks passed
@bloebp bloebp deleted the remove_feature_module branch November 17, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants