Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise display of notebook examples in documentation #1072

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

bloebp
Copy link
Member

@bloebp bloebp commented Nov 13, 2023

This change aims at providing a better overview of the notebooks by displaying them as separate cards instead of a card carousel.

Other changes:

  • Introductory examples and Real world-inspired examples are now more prominent with individual images and a grid layout by 2 per-row.
  • All other examples are now in a grid layout with 3 examples per row.
  • Clear outputs of some notebooks.
  • Fix issue with rendering counterfactual example notebook.
Screenshot 2023-11-13 at 11 31 48 Screenshot 2023-11-13 at 11 31 33

@bloebp bloebp requested a review from petergtz November 13, 2023 19:58
This change aims at providing a better overview of the notebooks by displaying them as separate cards instead of a card carousel.

Other changes:
- Introductory examples and Real world-inspired examples are now more prominent with individual images and a grid layout by 2 per-row.
- All other examples are now in a grid layout with 3 examples per row.
- Clear outputs of some notebooks.
- Fix issue with rendering counterfactual example notebook.

Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
@bloebp bloebp force-pushed the revise_notebook_docs branch from d9c6724 to bcb6d6e Compare November 13, 2023 22:33
@bloebp bloebp requested a review from amit-sharma November 14, 2023 00:19
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bloebp . I took a quick look and the proposed changes look good!

@bloebp bloebp merged commit 9d77022 into main Nov 15, 2023
@bloebp bloebp deleted the revise_notebook_docs branch November 15, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants