Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default parameter of SVC model in the GCM module #1075

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Change default parameter of SVC model in the GCM module #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dowhy/gcm/ml/classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def create_ada_boost_classifier(**kwargs) -> SklearnClassificationModel:


def create_support_vector_classifier(**kwargs) -> SklearnClassificationModel:
return SklearnClassificationModel(SVC(**kwargs))
return SklearnClassificationModel(SVC(**kwargs, probability=True))


def create_knn_classifier(**kwargs) -> SklearnClassificationModel:
Expand Down
7 changes: 7 additions & 0 deletions tests/gcm/ml/test_classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from flaky import flaky

from dowhy.gcm.ml import create_hist_gradient_boost_classifier, create_polynom_logistic_regression_classifier
from dowhy.gcm.ml.classification import create_support_vector_classifier


@flaky(max_runs=3)
Expand Down Expand Up @@ -58,3 +59,9 @@ def _generate_data():
mdl.fit(X_training, Y_training)

assert np.sum(mdl.predict(X_test).reshape(-1) == Y_test) > 950


def test_given_svc_model_then_supports_predict_probabilities():
mdl = create_support_vector_classifier()
mdl.fit(np.random.normal(0, 1, 100), np.random.choice(2, 100).astype(str))
mdl.predict_probabilities(np.random.normal(0, 1, 10))