Add compatibility between GCM and CausalModel class #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the causal graphs between the GCM and CausalModel part required some additional work to be converted. Now, a GCM can be used to initiate a CausalModel or CausalGraph and vice versa. Signed-off-by: Patrick Bloebaum <bloebp@amazon.com>
bloebp
force-pushed
the
add_causal_model_compatibility
branch
from
952c6ea to
9e2d47d
Compare
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the causal graphs between the GCM and CausalModel part required some additional work to be converted. Now, a GCM can be used to initiate a CausalModel or CausalGraph and vice versa.
This should improve the interoperability and makes it easier to switch between the functionalities.
However, after the change #943, this compatibility should be deprecated until the CausalModel and CausalGraph object is removed completely.