Remove DeepIV econml estimator from notebook and fix flaky test #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
|
Thanks a lot @amit-sharma for fixing the notebook. Can you clear all cell outputs? There are some at the bottom of the notebook. That way, we can make sure that the build fails in case the notebook does not work anymore in the future. |
Signed-off-by: Amit Sharma <amit_sharma@live.com>
|
ah, thanks. Good catch, I have removed them now |
bloebp
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeepIV is being deprecated by EconML.
Also removed all output from the notebook.