Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for frontdoor identification and a new set of tests #1093

Merged
merged 3 commits into from
Dec 3, 2023
Merged

Bug fix for frontdoor identification and a new set of tests #1093

merged 3 commits into from
Dec 3, 2023

Conversation

amit-sharma
Copy link
Member

Fixes #971

  • Frontdoor estimation now supports multiple candidate variables
  • TwoStageRegression, downstream estimator supports only a single frontdoor and returns an Error if frontdoor set with more than variable is given.
  • New test suite for frontdoor criterion with 4 test graphs

@amit-sharma
fixed frontdoor bug and added tests
150fbb1 
Signed-off-by: Amit Sharma <amit_sharma@live.com>
@amit-sharma
updated docstring
b1b9156 
Signed-off-by: Amit Sharma <amit_sharma@live.com>
@amit-sharma amit-sharma mentioned this pull request Dec 2, 2023
Closed
@amit-sharma amit-sharma requested a review from bloebp December 2, 2023 10:47
@amit-sharma
reformatted file
1568297 
Signed-off-by: Amit Sharma <amit_sharma@live.com>
@amit-sharma amit-sharma merged commit 048117c into main Dec 3, 2023
30 checks passed
@amit-sharma amit-sharma deleted the fix-frontdoor-id branch December 3, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloebp bloebp bloebp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontdoor estimation is wrong
2 participants
@amit-sharma @bloebp