Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library functions for temporal causal functionality #1218

Merged
merged 67 commits into from
Aug 3, 2024

Conversation

srivhash
Copy link
Contributor

These functions allow causal inference for temporal data. These helper functions help pre-process the dataframe according to the discovered temporal causal graph, which can be further used for causal effect estimation.

@srivhash
Copy link
Contributor Author

@amit-sharma The initial PR for temporal causal discovery has been created. Let us discuss, and work on further implementation plan

dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @srivhash The updates are helpful. I've added a few comments to add more documentation and clarity.

dowhy/timeseries/causal_effect_tutorial.ipynb Outdated Show resolved Hide resolved
dowhy/timeseries/causal_effect_tutorial.ipynb Outdated Show resolved Hide resolved
dowhy/timeseries/temporal_graph.csv Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/timeseries/timeseries.py Outdated Show resolved Hide resolved
dowhy/utils/plotting.py Outdated Show resolved Hide resolved
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice progress! Added some comments about notebook and docstring.

dowhy/timeseries/temporal_shift.py Outdated Show resolved Hide resolved
dowhy/timeseries/causal_effect_tutorial.ipynb Outdated Show resolved Hide resolved
dowhy/timeseries/causal_effect_tutorial.ipynb Outdated Show resolved Hide resolved
dowhy/timeseries/causal_effect_tutorial.ipynb Outdated Show resolved Hide resolved
dowhy/timeseries/causal_effect_tutorial.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is getting closer to completion!
Can you also add the test cases? you can create a new folder in tests/timeseries/?

dowhy/timeseries/temporal_shift.py Outdated Show resolved Hide resolved
dowhy/timeseries/temporal_shift.py Outdated Show resolved Hide resolved
dowhy/timeseries/temporal_shift.py Outdated Show resolved Hide resolved
dowhy/timeseries/causal_effect_tutorial.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the updates.

@amit-sharma amit-sharma merged commit becbf7f into py-why:main Aug 3, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants