-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library functions for temporal causal functionality #1218
Conversation
@amit-sharma The initial PR for temporal causal discovery has been created. Let us discuss, and work on further implementation plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @srivhash The updates are helpful. I've added a few comments to add more documentation and clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice progress! Added some comments about notebook and docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, this is getting closer to completion!
Can you also add the test cases? you can create a new folder in tests/timeseries/?
Signed-off-by: Amit Sharma <amit_sharma@live.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the updates.
These functions allow causal inference for temporal data. These helper functions help pre-process the dataframe according to the discovered temporal causal graph, which can be further used for causal effect estimation.