Skip to content

Lift restrictions on ESPResSo/NumPy/Pandas version requirements #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Nov 28, 2024

No description provided.

@pm-blanco pm-blanco self-requested a review November 29, 2024 11:58
@pm-blanco pm-blanco added this to the pyMBE 1.0.0 milestone Nov 29, 2024
Copy link
Collaborator

@pm-blanco pm-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jngrad thank you for taking care of updating our dependencies and solving some typos in the way! I checked and everything works with espresso v4.3 and v4.2. This is an important step forward enabling to combine pyMBE with other tools as MDAnalysis, opening the door of our goal to make our software more interoperable. I only have some minor comments:

Copy link
Collaborator

@pm-blanco pm-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Now the handy_tools library is exposed to Codecov, which reduces the code coverage. It makes me sad to see the code coverage go down but at the same time the estimate of the code coverage is now more fair, since all libraries are included, improving our transparency. Let's keep working on improving the coverage of the library with more CI test to bring the coverage of the library back up!

@pm-blanco pm-blanco merged commit da25a9b into pyMBE-dev:main Dec 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants