-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional deps if not using hatch #59
base: main
Are you sure you want to change the base?
Conversation
I'm not super happy with the optional dependencies listed in How about we wait until dependency-groups are fully supported by hatch and then give this a go? |
part of that might be differences in how we use that group/term? Between these two So maybe we take all the other optional deps out of I think it's worth doing in the short term for a few reasons:
|
I agree with this approach, it is similar to what we've used in Jupyter libraries. Having everything self-contained has been super helpful for contributors. |
222a6c6
to
49824fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
want to check with @Midnighter before merging since he expressed some reservations. is this ok or no good? :) edit: I didn't make the switch to an |
Go ahead, we can revisit this when new features are available. |
49824fd
to
99e5a80
Compare
@all-contributors please add @sneakers-the-rat for code, review |
I've put up a pull request to add @sneakers-the-rat! 🎉 |
Currently if you say "no" to using hatch envs but "yes" to all the bells and whistles, you end up with a package that doesn't have the optional dependencies needed to use them :(
so this completes another leg of the combinatoric labyrinth we are constructing here ;)
for a project
my_package
with hatch off...and nothing special is added:
and everything special is added
and the permutations in between.
I think this officially puts as at the time in every template's life where we need to start abstracting the values, because keeping deps synchronized will be tough.