Enable PTH123 rule (#100)

pySmartThings · Feb 6, 2025 · 915b85a · 915b85a
1 parent 18badcd
commit 915b85a
Show file tree

Hide file tree

Showing 87 changed files with 5 additions and 5 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -134,7 +134,6 @@ ignore = [
   "S105",
   "PGH004",
   "EXE001",
-  "PTH123",
   "T201",
   "COM812", # Conflicts with other rules
   "D203", # Conflicts with other rules

diff --git a/tests/json/app_get.json → tests/fixtures/app_get.json b/tests/json/app_get.json → tests/fixtures/app_get.json
diff --git a/tests/json/app_oauth_generate_request.json → .../fixtures/app_oauth_generate_request.json b/tests/json/app_oauth_generate_request.json → .../fixtures/app_oauth_generate_request.json
diff --git a/tests/json/app_oauth_generate_response.json → ...fixtures/app_oauth_generate_response.json b/tests/json/app_oauth_generate_response.json → ...fixtures/app_oauth_generate_response.json
diff --git a/tests/json/app_oauth_get_response.json → tests/fixtures/app_oauth_get_response.json b/tests/json/app_oauth_get_response.json → tests/fixtures/app_oauth_get_response.json
diff --git a/tests/json/app_oauth_put_request.json → tests/fixtures/app_oauth_put_request.json b/tests/json/app_oauth_put_request.json → tests/fixtures/app_oauth_put_request.json
diff --git a/tests/json/app_oauth_put_response.json → tests/fixtures/app_oauth_put_response.json b/tests/json/app_oauth_put_response.json → tests/fixtures/app_oauth_put_response.json
diff --git a/tests/json/app_post_request.json → tests/fixtures/app_post_request.json b/tests/json/app_post_request.json → tests/fixtures/app_post_request.json
diff --git a/tests/json/app_post_response.json → tests/fixtures/app_post_response.json b/tests/json/app_post_response.json → tests/fixtures/app_post_response.json
diff --git a/tests/json/app_put_request.json → tests/fixtures/app_put_request.json b/tests/json/app_put_request.json → tests/fixtures/app_put_request.json
diff --git a/tests/json/app_put_response.json → tests/fixtures/app_put_response.json b/tests/json/app_put_response.json → tests/fixtures/app_put_response.json
diff --git a/tests/json/app_settings.json → tests/fixtures/app_settings.json b/tests/json/app_settings.json → tests/fixtures/app_settings.json
diff --git a/tests/json/apps.json → tests/fixtures/apps.json b/tests/json/apps.json → tests/fixtures/apps.json
diff --git a/tests/json/device.json → tests/fixtures/device.json b/tests/json/device.json → tests/fixtures/device.json
diff --git a/...son/device_command_post_channel_down.json → ...res/device_command_post_channel_down.json b/...son/device_command_post_channel_down.json → ...res/device_command_post_channel_down.json
diff --git a/.../json/device_command_post_channel_up.json → ...tures/device_command_post_channel_up.json b/.../json/device_command_post_channel_up.json → ...tures/device_command_post_channel_up.json
diff --git a/tests/json/device_command_post_close.json → ...s/fixtures/device_command_post_close.json b/tests/json/device_command_post_close.json → ...s/fixtures/device_command_post_close.json
diff --git a/...son/device_command_post_close_legacy.json → ...res/device_command_post_close_legacy.json b/...son/device_command_post_close_legacy.json → ...res/device_command_post_close_legacy.json
diff --git a/...vice_command_post_close_window_shade.json → ...vice_command_post_close_window_shade.json b/...vice_command_post_close_window_shade.json → ...vice_command_post_close_window_shade.json
diff --git a/tests/json/device_command_post_execute.json → ...fixtures/device_command_post_execute.json b/tests/json/device_command_post_execute.json → ...fixtures/device_command_post_execute.json
diff --git a/...son/device_command_post_fast_forward.json → ...res/device_command_post_fast_forward.json b/...son/device_command_post_fast_forward.json → ...res/device_command_post_fast_forward.json
diff --git a/tests/json/device_command_post_lock.json → tests/fixtures/device_command_post_lock.json b/tests/json/device_command_post_lock.json → tests/fixtures/device_command_post_lock.json
diff --git a/tests/json/device_command_post_mute.json → tests/fixtures/device_command_post_mute.json b/tests/json/device_command_post_mute.json → tests/fixtures/device_command_post_mute.json
diff --git a/tests/json/device_command_post_open.json → tests/fixtures/device_command_post_open.json b/tests/json/device_command_post_open.json → tests/fixtures/device_command_post_open.json
diff --git a/...json/device_command_post_open_legacy.json → ...ures/device_command_post_open_legacy.json b/...json/device_command_post_open_legacy.json → ...ures/device_command_post_open_legacy.json
diff --git a/...evice_command_post_open_window_shade.json → ...evice_command_post_open_window_shade.json b/...evice_command_post_open_window_shade.json → ...evice_command_post_open_window_shade.json
diff --git a/...ce_command_post_override_drlc_action.json → ...ce_command_post_override_drlc_action.json b/...ce_command_post_override_drlc_action.json → ...ce_command_post_override_drlc_action.json
diff --git a/tests/json/device_command_post_pause.json → ...s/fixtures/device_command_post_pause.json b/tests/json/device_command_post_pause.json → ...s/fixtures/device_command_post_pause.json
diff --git a/tests/json/device_command_post_play.json → tests/fixtures/device_command_post_play.json b/tests/json/device_command_post_play.json → tests/fixtures/device_command_post_play.json
diff --git a/.../device_command_post_preset_position.json → .../device_command_post_preset_position.json b/.../device_command_post_preset_position.json → .../device_command_post_preset_position.json
diff --git a/...ice_command_post_request_drlc_action.json → ...ice_command_post_request_drlc_action.json b/...ice_command_post_request_drlc_action.json → ...ice_command_post_request_drlc_action.json
diff --git a/tests/json/device_command_post_rewind.json → .../fixtures/device_command_post_rewind.json b/tests/json/device_command_post_rewind.json → .../fixtures/device_command_post_rewind.json
diff --git a/...ommand_post_set_air_conditioner_mode.json → ...ommand_post_set_air_conditioner_mode.json b/...ommand_post_set_air_conditioner_mode.json → ...ommand_post_set_air_conditioner_mode.json
diff --git a/..._command_post_set_air_flow_direction.json → ..._command_post_set_air_flow_direction.json b/..._command_post_set_air_flow_direction.json → ..._command_post_set_air_flow_direction.json
diff --git a/...s/json/device_command_post_set_color.json → ...xtures/device_command_post_set_color.json b/...s/json/device_command_post_set_color.json → ...xtures/device_command_post_set_color.json
diff --git a/...on/device_command_post_set_color_hex.json → ...es/device_command_post_set_color_hex.json b/...on/device_command_post_set_color_hex.json → ...es/device_command_post_set_color_hex.json
diff --git a/...e_command_post_set_color_temperature.json → ...e_command_post_set_color_temperature.json b/...e_command_post_set_color_temperature.json → ...e_command_post_set_color_temperature.json
diff --git a/...ce_command_post_set_cooling_setpoint.json → ...ce_command_post_set_cooling_setpoint.json b/...ce_command_post_set_cooling_setpoint.json → ...ce_command_post_set_cooling_setpoint.json
diff --git a/...and_post_set_cooling_setpoint_legacy.json → ...and_post_set_cooling_setpoint_legacy.json b/...and_post_set_cooling_setpoint_legacy.json → ...and_post_set_cooling_setpoint_legacy.json
diff --git a/...son/device_command_post_set_fan_mode.json → ...res/device_command_post_set_fan_mode.json b/...son/device_command_post_set_fan_mode.json → ...res/device_command_post_set_fan_mode.json
diff --git a/...ommand_post_set_fan_oscillation_mode.json → ...ommand_post_set_fan_oscillation_mode.json b/...ommand_post_set_fan_oscillation_mode.json → ...ommand_post_set_fan_oscillation_mode.json
diff --git a/...on/device_command_post_set_fan_speed.json → ...es/device_command_post_set_fan_speed.json b/...on/device_command_post_set_fan_speed.json → ...es/device_command_post_set_fan_speed.json
diff --git a/...ce_command_post_set_heating_setpoint.json → ...ce_command_post_set_heating_setpoint.json b/...ce_command_post_set_heating_setpoint.json → ...ce_command_post_set_heating_setpoint.json
diff --git a/...and_post_set_heating_setpoint_legacy.json → ...and_post_set_heating_setpoint_legacy.json b/...and_post_set_heating_setpoint_legacy.json → ...and_post_set_heating_setpoint_legacy.json
diff --git a/tests/json/device_command_post_set_hue.json → ...fixtures/device_command_post_set_hue.json b/tests/json/device_command_post_set_hue.json → ...fixtures/device_command_post_set_hue.json
diff --git a/...device_command_post_set_input_source.json → ...device_command_post_set_input_source.json b/...device_command_post_set_input_source.json → ...device_command_post_set_input_source.json
diff --git a/...s/json/device_command_post_set_level.json → ...xtures/device_command_post_set_level.json b/...s/json/device_command_post_set_level.json → ...xtures/device_command_post_set_level.json
diff --git a/...ce_command_post_set_playback_shuffle.json → ...ce_command_post_set_playback_shuffle.json b/...ce_command_post_set_playback_shuffle.json → ...ce_command_post_set_playback_shuffle.json
diff --git a/.../json/device_command_post_set_repeat.json → ...tures/device_command_post_set_repeat.json b/.../json/device_command_post_set_repeat.json → ...tures/device_command_post_set_repeat.json
diff --git a/...n/device_command_post_set_saturation.json → ...s/device_command_post_set_saturation.json b/...n/device_command_post_set_saturation.json → ...s/device_command_post_set_saturation.json
diff --git a/.../device_command_post_set_shade_level.json → .../device_command_post_set_shade_level.json b/.../device_command_post_set_shade_level.json → .../device_command_post_set_shade_level.json
diff --git a/...command_post_set_thermostat_fan_mode.json → ...command_post_set_thermostat_fan_mode.json b/...command_post_set_thermostat_fan_mode.json → ...command_post_set_thermostat_fan_mode.json
diff --git a/..._post_set_thermostat_fan_mode_legacy.json → ..._post_set_thermostat_fan_mode_legacy.json b/..._post_set_thermostat_fan_mode_legacy.json → ..._post_set_thermostat_fan_mode_legacy.json
diff --git a/...ice_command_post_set_thermostat_mode.json → ...ice_command_post_set_thermostat_mode.json b/...ice_command_post_set_thermostat_mode.json → ...ice_command_post_set_thermostat_mode.json
diff --git a/...mand_post_set_thermostat_mode_legacy.json → ...mand_post_set_thermostat_mode_legacy.json b/...mand_post_set_thermostat_mode_legacy.json → ...mand_post_set_thermostat_mode_legacy.json
diff --git a/...n/device_command_post_set_tv_channel.json → ...s/device_command_post_set_tv_channel.json b/...n/device_command_post_set_tv_channel.json → ...s/device_command_post_set_tv_channel.json
diff --git a/.../json/device_command_post_set_volume.json → ...tures/device_command_post_set_volume.json b/.../json/device_command_post_set_volume.json → ...tures/device_command_post_set_volume.json
diff --git a/tests/json/device_command_post_stop.json → tests/fixtures/device_command_post_stop.json b/tests/json/device_command_post_stop.json → tests/fixtures/device_command_post_stop.json
diff --git a/.../json/device_command_post_switch_off.json → ...tures/device_command_post_switch_off.json b/.../json/device_command_post_switch_off.json → ...tures/device_command_post_switch_off.json
diff --git a/...s/json/device_command_post_switch_on.json → ...xtures/device_command_post_switch_on.json b/...s/json/device_command_post_switch_on.json → ...xtures/device_command_post_switch_on.json
diff --git a/tests/json/device_command_post_unlock.json → .../fixtures/device_command_post_unlock.json b/tests/json/device_command_post_unlock.json → .../fixtures/device_command_post_unlock.json
diff --git a/tests/json/device_command_post_unmute.json → .../fixtures/device_command_post_unmute.json b/tests/json/device_command_post_unmute.json → .../fixtures/device_command_post_unmute.json
diff --git a/...json/device_command_post_volume_down.json → ...ures/device_command_post_volume_down.json b/...json/device_command_post_volume_down.json → ...ures/device_command_post_volume_down.json
diff --git a/...s/json/device_command_post_volume_up.json → ...xtures/device_command_post_volume_up.json b/...s/json/device_command_post_volume_up.json → ...xtures/device_command_post_volume_up.json
diff --git a/tests/json/device_samsungac_status.json → tests/fixtures/device_samsungac_status.json b/tests/json/device_samsungac_status.json → tests/fixtures/device_samsungac_status.json
diff --git a/tests/json/device_status.json → tests/fixtures/device_status.json b/tests/json/device_status.json → tests/fixtures/device_status.json
diff --git a/tests/json/devices.json → tests/fixtures/devices.json b/tests/json/devices.json → tests/fixtures/devices.json
diff --git a/tests/json/devices_filtered.json → tests/fixtures/devices_filtered.json b/tests/json/devices_filtered.json → tests/fixtures/devices_filtered.json
diff --git a/tests/json/installedapp_get_response.json → ...s/fixtures/installedapp_get_response.json b/tests/json/installedapp_get_response.json → ...s/fixtures/installedapp_get_response.json
diff --git a/tests/json/installedapps_get_response.json → .../fixtures/installedapps_get_response.json b/tests/json/installedapps_get_response.json → .../fixtures/installedapps_get_response.json
diff --git a/tests/json/installedapps_get_response_2.json → ...ixtures/installedapps_get_response_2.json b/tests/json/installedapps_get_response_2.json → ...ixtures/installedapps_get_response_2.json
diff --git a/tests/json/location.json → tests/fixtures/location.json b/tests/json/location.json → tests/fixtures/location.json
diff --git a/tests/json/locations.json → tests/fixtures/locations.json b/tests/json/locations.json → tests/fixtures/locations.json
diff --git a/tests/json/room.json → tests/fixtures/room.json b/tests/json/room.json → tests/fixtures/room.json
diff --git a/tests/json/room_post.json → tests/fixtures/room_post.json b/tests/json/room_post.json → tests/fixtures/room_post.json
diff --git a/tests/json/room_put.json → tests/fixtures/room_put.json b/tests/json/room_put.json → tests/fixtures/room_put.json
diff --git a/tests/json/rooms.json → tests/fixtures/rooms.json b/tests/json/rooms.json → tests/fixtures/rooms.json
diff --git a/tests/json/scenes.json → tests/fixtures/scenes.json b/tests/json/scenes.json → tests/fixtures/scenes.json
diff --git a/tests/json/scenes_location_filter.json → tests/fixtures/scenes_location_filter.json b/tests/json/scenes_location_filter.json → tests/fixtures/scenes_location_filter.json
diff --git a/...subscription_capability_get_response.json → ...subscription_capability_get_response.json b/...subscription_capability_get_response.json → ...subscription_capability_get_response.json
diff --git a/...son/subscription_device_get_response.json → ...res/subscription_device_get_response.json b/...son/subscription_device_get_response.json → ...res/subscription_device_get_response.json
diff --git a/tests/json/subscription_post_request.json → ...s/fixtures/subscription_post_request.json b/tests/json/subscription_post_request.json → ...s/fixtures/subscription_post_request.json
diff --git a/tests/json/subscription_post_response.json → .../fixtures/subscription_post_response.json b/tests/json/subscription_post_response.json → .../fixtures/subscription_post_response.json
diff --git a/tests/json/subscriptions_get_response.json → .../fixtures/subscriptions_get_response.json b/tests/json/subscriptions_get_response.json → .../fixtures/subscriptions_get_response.json
diff --git a/tests/json/token_invalid_response.json → tests/fixtures/token_invalid_response.json b/tests/json/token_invalid_response.json → tests/fixtures/token_invalid_response.json
diff --git a/tests/json/token_response.json → tests/fixtures/token_response.json b/tests/json/token_response.json → tests/fixtures/token_response.json
diff --git a/tests/utilities.py b/tests/utilities.py
@@ -2,13 +2,14 @@
 
 from __future__ import annotations
 
-import json as _json
+from pathlib import Path
 from typing import Optional, Union, TYPE_CHECKING
 from urllib.parse import parse_qs
 
 from aiohttp import ClientSession
 from aiohttp.client_exceptions import ClientResponseError
 from yarl import URL
+import json as _json
 
 if TYPE_CHECKING:
     from collections.abc import Sequence
@@ -17,10 +18,10 @@
 BodyType = Optional[Union[list, dict]]
 
 
-def get_json(file):
+def get_json(filename: str) -> dict | list:
     """Load a json file."""
-    with open("tests/json/" + file, encoding="utf-8") as json_file:
-        return _json.load(json_file)
+    path = Path(__package__) / "fixtures" / filename
+    return _json.loads(path.read_text(encoding="utf-8"))
 
 
 def _get_json_fixture(body: BodyFixtureType) -> BodyType: