Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmake): support DEBUG_POSTFIX correctly #4761

Merged
merged 3 commits into from
Sep 15, 2023
Merged

fix(cmake): support DEBUG_POSTFIX correctly #4761

merged 3 commits into from
Sep 15, 2023

Commits on Jul 25, 2023

  1. cmake: split extension 

    Into suffix and debug postfix. Pybind11 is currently treating both as
suffix, which is problematic when something else defines the
DEBUG_POSTFIX because they will be concatenated.

pybind11_extension sets SUFFIX to _d.something and if DEBUG_POSTFIX is
set to _d.

    _d + _d.something = _d_d.something

The issue has been reported at:

pybind#4699
    @lpapp-foundry
    lpapp-foundry committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    04dc993 View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6d1d8df View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. fix(cmake): support postfix for old FindPythonInterp mode too 

    Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
    @henryiii
    henryiii committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8e3a451 View commit details
    Browse the repository at this point in the history