-
Notifications
You must be signed in to change notification settings - Fork 22
Catch a syntax error when parsing an input file with the --stay-connected flag active #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shaggysa
wants to merge
18
commits into
pybricks:master
Choose a base branch
from
shaggysa:feature/catch-syntax-error
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+571
−127
Open
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d1c1309
cli/__init__.py: catch a syntax error when re-compiling the target file
shaggysa 8b5eb9c
cli/__init__.py: slightly modify the error message warning
shaggysa e95fc0e
cli/__init__.py: refactor to allow the catching of syntax errors on t…
shaggysa c3f3c20
cli/__init__.py: clean up an if statement
shaggysa 709e6f1
CHANGELOG.md: add an entry for the new changes to the run command
shaggysa aedee30
cli/__init__.py: avoid using newline escape characters
shaggysa 7a1ca00
cli/__init__.py: move stay_connected_menu to separate function
shaggysa 4d72397
Merge branch 'master' into feature/catch-syntax-error
dlech 9f71013
explicitly pass args to the stay-connected menu from the run function
shaggysa 972b4a7
Merge remote-tracking branch 'origin/feature/catch-syntax-error' into…
shaggysa b31f93c
Merge branch 'pybricks:master' into feature/catch-syntax-error
shaggysa 1e0e8bc
catch a CalledProcessError and decode stderr
shaggysa d7cd4bd
fix typo in except block
shaggysa 681acee
add a few unit tests related to stay_connected_menu
shaggysa ec917ab
make the open() call in the "Change Target File" option explicitly sp…
shaggysa 45fed26
fix leaking coroutines in test_stay_connected_menu_interruptions
shaggysa 9577550
add a test for the `Run Stored Program` option
shaggysa 4e3f4b8
rearrange test order
shaggysa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.