Conversation
The existing load benchmarks create a fresh object each iteration, so
the cache is always cold and caching optimisations show no benefit there.
Add benchmarks that construct the object once and then repeatedly call
the getter, exercising the warm-cache path:
Certificate : subject, issuer, public_key(),
signature_hash_algorithm, signature_algorithm_oid
CRL : issuer, serial-number lookup (hit and miss)
OCSPRequest : issuer_name_hash, issuer_key_hash,
hash_algorithm, serial_number (all in one bench)
OCSPResponse: issuer_key_hash, serial_number,
signature_hash_algorithm (all in one bench)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Wrap the attributes getter in PyOnceLock so the expensive loop over ASN.1 attributes (OID conversion, PyBytes allocation, Attributes construction) runs at most once per CertificateSigningRequest object. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Contributor
Author
|
I have few more PRs outstanding to complete property caching optimizations. They all depend on each other, thus on this one as well. |
alex
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of #14441
Also adds a benchmark of property access.