Negative serial numbers are mega deprecated #9897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperhulk
approved these changes
Nov 18, 2023
|
Nice, and thanks for the ping! Once they're fully disallowed, I think the |
|
Yes, we will.
…On Sat, Nov 18, 2023 at 7:40 PM William Woodruff ***@***.***> wrote:
Nice, and thanks for the ping!
Once they're fully disallowed, I think the Certificate type could switch
to BigUint for its serial type, right?
—
Reply to this email directly, view it on GitHub
<#9897 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBHKMURHDDUQ5SRBXATYFFIO7AVCNFSM6AAAAAA7RG3FAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXG4YDEMJQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
intgr
reviewed
Jul 22, 2024
Comment on lines
+46
to
+47
| * In the next release (43.0.0) of cryptography, loading an X.509 certificate | ||
| with a negative serial number will raise an exception. This has been |
There was a problem hiding this comment.
43.0.0 was released, but no mention of this. See #10247 (comment)
There was a problem hiding this comment.
Just for others who might find this: we didn't remove support in 43 (as noted in #10247 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: @woodruffw