Add "Bug Tracker" and "Documentation" links to pyproject.toml #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Jun 26, 2024
alltilla
force-pushed
the
pypi-bug-tracker-and-documentation-links
branch
from
7ec5502
to
689316d
Compare
alltilla
changed the title
|
Hmm it seems like starting a |
|
Interesting, looks like we have to migrate a few other properties over
first. If you're up for it, that'd be a great contribution, if not I'll
make time to work on this shortly.
…On Wed, Jun 26, 2024 at 8:38 AM Attila Szakacs ***@***.***> wrote:
Hmm it seems like starting a project block in pyproject.toml conflicts
with setup.py.
py312: packaging backend failed (code=1), with ValueError: invalid pyproject.toml config: `project`.
configuration error: `project` must contain ['name'] properties
—
Reply to this email directly, view it on GitHub
<#826 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBAFDZ2BVGBQETQU3YTZJKY4NAVCNFSM6AAAAABJ5PXZV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRGU4DSMJWGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
|
Yes, I'd like to try that, but feel free to implement it yourself anytime if you need this sooner. :) |
|
I won't get to it this weekend, so if you're up for it, please have a shot!
…On Wed, Jun 26, 2024 at 6:03 PM Attila Szakacs ***@***.***> wrote:
Yes, I'd like to try that, but feel free to implement it yourself anytime if you need this sooner. :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
|
We've now got a basic pyproject.toml, so you should be able to rebase on main and do this now. |
alltilla
force-pushed
the
pypi-bug-tracker-and-documentation-links
branch
from
689316d
to
567a6e2
Compare
They show up on the pypi page on the left, making them easier to find. Based on: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#urls Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
|
Thanks, kind of you to leave the urls section to me :) Rebased and updated the PR. |
alltilla
force-pushed
the
pypi-bug-tracker-and-documentation-links
branch
from
567a6e2
to
3a32902
Compare
alex
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They show up on the pypi page on the left, making them easier to find.
Based on:
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#urls