-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(dockerfile): enhanced production dockerfile #1151
Conversation
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1151 +/- ##
==========================================
+ Coverage 69.74% 70.21% +0.47%
==========================================
Files 85 85
Lines 3378 3381 +3
==========================================
+ Hits 2356 2374 +18
+ Misses 1022 1007 -15
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iknowright for making this change, I think we also need to apply these changes todev.Dockerfile
. Could you help me update that?
Updated. |
67e8000
to
e97e4e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Types of changes
Description
Use multi-stage feature on Docker to enable easy-read and better maintenance for Dockerfile
Two stages: node_stage and python_stage
node_stage:
FROM
, we can specify docker image taf and get the node run-time with no extra works (nvm and hardcoded download link)python_stage:
Notes:
Steps to Test This Pull Request
Expected behavior
Size reduced up to 50% and more
from the staging environment, test results are as follow:
pycontw-2023_web-enhanced-dockerfile latest e620e4f466ac 24 seconds ago 626MB
pycontw-2023_web latest 11ff9f780b7d 2 weeks ago 1.56GB
closes #1139