Skip to content

Commit

Permalink
Merge pull request #430 from pycontw/fix/navbar
Browse files Browse the repository at this point in the history
fix(header): reduce horizontal padding in header
  • Loading branch information
yungshenglu authored Aug 17, 2023
2 parents a3e30cd + a724085 commit 1ccabbb
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions components/core/header/Header.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
import HomeIcon from './HomeIcon'
import NavBar from './nav-bar/NavBar'
import NavBarHamburger from './nav-bar/NavBarHamburger'
import ScrollableNavBar from './nav-bar/ScrollableNavBar'
import LocaleSwitch from './locale-switch/LocaleSwitch'
import ScrollableNavBar from './nav-bar/ScrollableNavBar'
export default {
name: 'CoreHeader',
components: {
Expand All @@ -47,7 +47,7 @@ export default {
}
.header__nav-bar {
@apply flex w-full items-center justify-between px-4;
@apply flex w-full items-center justify-between px-2;
pointer-events: auto; /*enable click-through ScrollableNavBar*/
}
.header-container,
Expand Down
3 changes: 2 additions & 1 deletion components/core/header/HomeIcon.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<locale-link
to="/"
class="core-homeIcon flex items-center justify-center py-2 md:px-8"
class="core-homeIcon flex items-center justify-center py-2 md:px-4"
customized
>
<img
Expand Down Expand Up @@ -35,5 +35,6 @@ export default {
<style scoped>
.core-homeIcon {
@apply text-pink-700;
flex-shrink: 0;
}
</style>
1 change: 1 addition & 0 deletions components/core/header/locale-switch/LocaleSwitch.vue
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export default {
<style lang="postcss" scoped>
.core-localeSwitch {
@apply font-bold;
flex-shrink: 0;
}
.core-localeSwitch:hover {
@apply text-pink-700;
Expand Down
2 changes: 1 addition & 1 deletion components/core/header/nav-bar/NavBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export default {
'h-full': isLink,
'justify-center': isLink,
'items-center': isLink,
'px-8': isLink,
'px-4': isLink,
'py-2': isLink,
'bg-transparent': !isOnCurrentPath,
'--active': isOnCurrentPath,
Expand Down
2 changes: 1 addition & 1 deletion components/core/header/nav-bar/NavBarItemDropdown.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div
class="relative flex h-full items-center justify-center px-8 text-left"
class="relative flex h-full items-center justify-center px-5 text-left"
@mouseenter="showMenu"
@mouseleave="hideMenu"
>
Expand Down
2 changes: 1 addition & 1 deletion components/core/header/nav-bar/ScrollableNavBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export default {
.core-scrollableNavBar,
.core-scrollableNavBar__scroll,
.core-scrollableNavBar__slot {
@apply h-full w-full;
@apply h-full max-w-full;
}
.core-scrollableNavBar__left-arrow,
.core-scrollableNavBar__right-arrow {
Expand Down

0 comments on commit 1ccabbb

Please sign in to comment.