fix(keynote): prevent replaceAll on null when speaker_name_en_us is e…

…mpty
pycontw · Aug 4, 2023 · b2f496f · b2f496f
1 parent fdbe5fd
commit b2f496f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/components/schedule/ScheduleEvent.vue b/components/schedule/ScheduleEvent.vue
@@ -130,7 +130,7 @@ export default {
                 event_id: eventId,
                 speakers,
             } = this.value
-            if (eventType === 'keynote') {
+            if (eventType === 'keynote' && speakers[0].en_us) {
                 const keynoteSpeakerId = speakers[0].en_us
                     .replaceAll(' ', '_')
                     .replaceAll('.', '')

diff --git a/pages/conference/keynotes.vue b/pages/conference/keynotes.vue
@@ -168,9 +168,11 @@ export default {
     },
     methods: {
         getKeynoteId(keynote) {
-            return keynote.speaker.name_en_us
-                .replaceAll(' ', '_')
-                .replaceAll('.', '')
+            if (keynote.speaker.name_en_us) {
+                return keynote.speaker.name_en_us
+                    .replaceAll(' ', '_')
+                    .replaceAll('.', '')
+            }
         },
         getAttributeByLocale(data, attr) {
             const localeMap = { 'en-us': 'en_us', 'zh-hant': 'zh_hant' }