feat: ui venue change #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ephemeral-sable-89c7e0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
josix
reviewed
Jul 15, 2023
There was a problem hiding this comment.
Thanks to @baby230211. I'll update some missing descriptions latter.
components/venue/VenueDivision.vue
Outdated
| export default { | ||
| name: 'VenueDivision', | ||
| props: { | ||
| index: { type: Number, default: -1 }, |
There was a problem hiding this comment.
question: what is index used for? I didn't see it referenced in this component.
There was a problem hiding this comment.
sorry, this should be removed!!
yungshenglu
reviewed
Jul 25, 2023
yungshenglu
reviewed
Jul 25, 2023
yungshenglu
reviewed
Jul 25, 2023
components/venue/VenueDriveTab.vue
Outdated
Comment on lines
127
to
139
| icon() { | ||
| if (this.$i18n.locale === 'en-us') { | ||
| return { | ||
| car: require('~/static/img/venue/car.svg'), | ||
| carWhite: require('~/static/img/venue/car-white.svg'), | ||
| motorWhite: require('~/static/img/venue/motor-white.svg'), | ||
| parking: require('~/static/img/venue/parking.svg'), | ||
| parkingPink: require('~/static/img/venue/parking-pink.svg'), | ||
| venueDestination: require('~/static/img/venue/en-us/venue-destination.svg'), | ||
| venueDestinationMd: require('~/static/img/venue/en-us/venue-destination-md.svg'), | ||
| } | ||
| } | ||
| return { |
There was a problem hiding this comment.
venueDestination, venueDestinationMd
image path is different when getting in different locale
There was a problem hiding this comment.
建議只要把不同的放進去條件判斷就好，兩邊寫在外面就可以
yungshenglu
reviewed
Jul 25, 2023
yungshenglu
reviewed
Jul 25, 2023
Comment on lines
226
to
239
| if (this.$i18n.locale === 'en-us') { | ||
| return { | ||
| carWhite: require('~/static/img/venue/car-white.svg'), | ||
| busWhite: require('~/static/img/venue/bus-white.svg'), | ||
| publicTransporterGuide: require('~/static/img/venue/en-us/publicTransporterGuide.svg'), | ||
| publicTransporterGuideMd: require('~/static/img/venue/en-us/publicTransporterGuide-md.svg'), | ||
| taxiWhite: require('~/static/img/venue/taxi-white.svg'), | ||
| transporterWhite: require('~/static/img/venue/transporter-white.svg'), | ||
| uBike: require('~/static/img/venue/uBike.svg'), | ||
| parking: require('~/static/img/venue/parking.svg'), | ||
| airplane: require('~/static/img/venue/airplane.svg'), | ||
| } | ||
| } | ||
| return { |
yungshenglu
reviewed
Jul 25, 2023
yungshenglu
reviewed
Jul 25, 2023
i18n/venue/index.i18n.js
Outdated
| bus: { | ||
| title: 'Passenger bus', | ||
| description: | ||
| "To reach Academia Sinica, you can take buses 205, 212, 212 直 (212 Express), 270, 270 區 (270 Shuttle), 276, 306, 306 區 (306 Shuttle), 620, 645, 645 副 (645 Sub), S1, S12, 小 12 區 (S12 Shuttle), S5, or 藍 25 (Blue 25), and get off at Academia Sinica Station. From there, it's approximately an 8-minute walk to your destination.", |
There was a problem hiding this comment.
the text is same as figma ui
There was a problem hiding this comment.
文案建議可以討論一下，避免中英文夾雜，非中文母語者應該也是看不懂中文的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Steps to Test This Pull Request
Expected behavior
Related Issue
Additional context