feat(staff page)- update list #447
Conversation
update_new_photo based on the list
✅ Deploy Preview for ephemeral-sable-89c7e0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| teamName: 'Vice Chairperson', | ||
| }, | ||
| { | ||
| key: 'everywhere', |
There was a problem hiding this comment.
- 拿掉 everywhere 是有跟誰確認過嗎？如果確定要拿掉那 staff.vue 裡面的 array 也可以刪掉了
- 為何只刪英文版部分？中文版卻留著？
- 有新增 pycast 的照片但是這裡卻沒新增 pycast 的類別？
There was a problem hiding this comment.
謝謝你注意到了!
-everywhere: 以為圖庫跟大會Excel裡面都沒有這個類別就把他刪除了. 還是有什麼列入方式(重複出現3次就到everywhere, 或有固定班底)？
-pycast: 已新增
There was a problem hiding this comment.
沒有固定規則，名單由當年度總招決定，可以把問題丟給 winnie & pochun
pages/about/staff.vue
Outdated
| { name: 'Po-Chun Lu', photo: 'cat-smile.png' }, | ||
| { name: 'Keith Yang', photo: 'reviewer/keith.jpg' }, | ||
| { name: 'Max Lai', photo: 'cat-smile.png' }, | ||
| { name: 'PeterWolf', photo: 'cat-smile.png' }, | ||
| { name: 'Ing Wei Tang', photo: 'reviewer/ingwei.jpg' }, | ||
| { name: '柯維然', photo: 'cat-smile.png' }, | ||
| { name: 'Winnie', photo: 'program/Winnie.jpeg' }, | ||
| { name: 'Jordan', photo: 'program/Jordan.jpg' }, | ||
| { name: 'Jordan', photo: 'cat-smile.png' }, |
There was a problem hiding this comment.
這種明顯是同一人、但今年沒有上傳照片的，要不要直接使用舊照片？
光是照片大小，每個人都不一樣，格式我覺得還好，都顯得出來就好 |
Checked! I did it manually (WE'VE GOTTA FIND A BETTER WAY NEXT YEAR |
|
這真的是每年開發最繁雜無聊的頁面（對人名、收集照片、修照片 etc）XDD，真的辛苦了！！ 幾個可以修正的 ideas
|
Types of changes
Description
update new photo based on the list and drive
Steps to Test This Pull Request
Steps to reproduce the behavior:
Expected behavior
Related Issue
#438
Additional context