Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(poster-session): add poster-session UI #555

Merged
merged 10 commits into from
Jul 21, 2024

Conversation

mhsiungw
Copy link
Contributor

Types of changes

  • New feature

Description

  1. 需求參考
  2. 因需要 render markdown syntax,所以 disable eslint rule 與沒有使用 scoped css
<!-- eslint-disable vue/no-v-html -->
  1. 調整海報募集文案

@mhsiungw mhsiungw requested a review from SivanYeh July 15, 2024 12:31
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit dc04ac2
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/669a622617b3e500085f2a65
😎 Deploy Preview https://deploy-preview-555--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit dc04ac2
🔍 Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/669a62262e106e000887fdd2
😎 Deploy Preview https://deploy-preview-555--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SivanYeh
Copy link
Collaborator

SivanYeh commented Jul 16, 2024

哇!在時限下做的很有模有樣
我們一起看看有沒有辦法在週日前把他與整體風格(尤其Talks and Tutorials這兩個頁面)整合的更好~
內容有點多,我這兩天晚上仔細看個

先問下:過程你有參考過Event Card(pages/events/overview.vue)嗎?

@mhsiungw
Copy link
Contributor Author

mhsiungw commented Jul 16, 2024

pages/events/overview.vue

@SivanYeh

UI 是以提供的資料(需求參考)為主,所以沒有參考 Event Card 的資料

@SivanYeh
Copy link
Collaborator

以提供的UI為主。不過提供的UI沒有動態細節資訊在上面(例如點擊前Modal的變色)。這部份是我覺得可以整合其他Modal的地方

@mhsiungw
Copy link
Contributor Author

以提供的UI為主。不過提供的UI沒有動態細節資訊在上面(例如點擊前Modal的變色)。這部份是我覺得可以整合其他Modal的地方

點擊前 Modal 的變色是指附圖嗎?
Screenshot 2024-07-16 at 9 14 18 PM

@SivanYeh
Copy link
Collaborator

SivanYeh commented Jul 16, 2024

對,目前這部分是比較明顯的。另外一個是rwd版的間距。
image
image
不過後者比較細微,時間不夠可以未來再討論調整。

@mhsiungw
Copy link
Contributor Author

mhsiungw commented Jul 17, 2024

對,目前這部分是比較明顯的。另外一個是rwd版的間距。 image image 不過後者比較細微,時間不夠可以未來再討論調整。

已針對 hover 後的 UI 做調整。

另調整了 banner 的部分,讓其佔據整個頁面

@SivanYeh
Copy link
Collaborator

Awesome works! UI部分我沒問題了. 其他屬於naming convention的想法我直接發在PR#557.
如果你看過ok給review approve後, 我們就可以合併起來先將Preview連結發在討論串提早請他們一起驗收了(加速進程的方法).

剩文稿校對. 我找人一起來看下

@mhsiungw
Copy link
Contributor Author

mhsiungw commented Jul 18, 2024

#557 已 approved,那我直接 merge #557 囉?

@SivanYeh
Copy link
Collaborator

#557 已 approved,那我直接 merge #557 囉?
來~

refactor(conference): naming in poster-session
@CharisLai
Copy link
Contributor

Hi @mhsiungw @SivanYeh, i18n 有與Excel 內容核對過 OK
然而在內文中有一處 typo 需請 議程組 與 Poster session 相關志工確認
謝謝~

@mhsiungw
Copy link
Contributor Author

@SivanYeh @CharisLai
已依照附圖的需求修改與調整內文,再麻煩 Sivan 和 Charis review,
如果沒問題應該可以直接 prod 嗎?
其它 UI 的調整是否如 Discord 討論的結果放到下個 step 再做修正?

Screenshot 2024-07-20 at 11 17 21 AM

@SivanYeh
Copy link
Collaborator

LGTM!

@mhsiungw mhsiungw requested a review from CharisLai July 21, 2024 01:57
@SivanYeh SivanYeh merged commit a4b0267 into main Jul 21, 2024
9 checks passed
@SivanYeh SivanYeh deleted the feature/add-poster-session-page-UI branch July 21, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants