-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(poster-session): add poster-session UI #555
Conversation
✅ Deploy Preview for zesty-gnome-f04144 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for classy-granita-bc2b5a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
以提供的UI為主。不過提供的UI沒有動態細節資訊在上面(例如點擊前Modal的變色)。這部份是我覺得可以整合其他Modal的地方 |
Awesome works! UI部分我沒問題了. 其他屬於naming convention的想法我直接發在PR#557. 剩文稿校對. 我找人一起來看下 |
refactor(conference): naming in poster-session
@SivanYeh @CharisLai |
LGTM! |
Types of changes
Description
eslint
rule 與沒有使用 scoped css