Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(staff): 2024 staff #567

Merged
merged 24 commits into from
Aug 17, 2024
Merged

feat(staff): 2024 staff #567

merged 24 commits into from
Aug 17, 2024

Conversation

SivanYeh
Copy link
Collaborator

Types of changes

  • New feature

Description

Toggle and update 2024 staff list on staff page.

Steps to Test This Pull Request

  1. Go To path/2024/zh-hant/about/staff and see the page

Expected behavior

image

Copy link

netlify bot commented Aug 17, 2024

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit c4ff059
🔍 Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/66c0b3fb85045700089927cf
😎 Deploy Preview https://deploy-preview-567--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 17, 2024

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit c4ff059
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66c0b3fb1ccc5d0008fd1da4
😎 Deploy Preview https://deploy-preview-567--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@foxlee2525 foxlee2525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SivanYeh SivanYeh merged commit ed31e29 into main Aug 17, 2024
9 checks passed
@SivanYeh SivanYeh deleted the feat/2024-staff branch August 17, 2024 14:39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's venve?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch!
@Ritabear Can you fix the typo?

@SivanYeh SivanYeh restored the feat/2024-staff branch August 19, 2024 23:51
@mattwang44 mattwang44 deleted the feat/2024-staff branch August 20, 2024 00:16
@mattwang44 mattwang44 restored the feat/2024-staff branch August 20, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants