refactor: Adjust Breakpoints for about/coc Page and Discuss lg Configuration Change #573
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue where the grid layout did not activate at the intended screen size.
👷 Deploy request for classy-granita-bc2b5a pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for zesty-gnome-f04144 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
josix
approved these changes
Aug 20, 2024
|
@foxlee2525 如果把tailwind.config.js lg改成1024會如何？ |
…odify affected pages - Refactored Tailwind `lg` breakpoint from 1024px to 1194px in tailwind.config.js. - Updated affected pages and media queries to align with the new breakpoint and ensure consistent grid behavior.
測試已知 「overview」 跟 「poster-session」兩個頁面的佈局受影響最大，所以相關頁面有做調整。 其他佈局目前看起來沒什麼問題，但可能還是要麻煩各位大大幫忙檢查一下，感謝！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
在調整
about/coc頁面的兩欄佈局斷點時，發現與專案中定義的lg斷點設定不一致，因此進行了調整，以符合網頁 RWD 標準。Discussion Needed
建議將 TailwindCSS config 的
lg斷點從1194px修改為1024px，以更符合常見的 RWD 標準。因為變動可能會影響到專案其他部分，因此希望先進行討論，再確認是否需要進行修改。
Next Steps
根據討論結果，確認是否需要將 TailwindCSS 配置中的 lg 斷點從 1194px 修改為 1024px。