Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usage of node12 which is deprecated in CI #153

Conversation

hamirmahal
Copy link
Contributor

fixes #152.

Copy link

codspeed-hq bot commented Oct 16, 2024

CodSpeed Performance Report

Merging #153 will not alter performance

Comparing hamirmahal:fix/usage-of-node12-which-is-deprecated-in-CI (bb6032c) with main (419ec90)

Summary

✅ 73 untouched benchmarks

@@ -579,16 +578,16 @@ jobs:
environment: release

steps:
- uses: actions/checkout@v2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 is the latest major version of actions/checkout at the time of this writing.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (419ec90) to head (bb6032c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          12       12           
  Lines        2042     2042           
  Branches     2042     2042           
=======================================
  Hits         1857     1857           
  Misses        112      112           
  Partials       73       73           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419ec90...bb6032c. Read the comment docs.

Copy link
Collaborator

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@davidhewitt davidhewitt enabled auto-merge (squash) October 24, 2024 12:34
@davidhewitt davidhewitt merged commit e2eb415 into pydantic:main Oct 24, 2024
24 checks passed
@hamirmahal hamirmahal deleted the fix/usage-of-node12-which-is-deprecated-in-CI branch October 24, 2024 18:01
@hamirmahal
Copy link
Contributor Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI uses node12 which is deprecated
2 participants