Add option to preserve empty URL paths #1789
Open
+361
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1789 will not alter performanceComparing Summary
|
Viicos
changed the title
Viicos
approved these changes
Sep 29, 2025
| } | ||
|
|
||
| pub fn __str__(&self) -> String { | ||
| pub fn __str__(&self, py: Python<'_>) -> String { |
There was a problem hiding this comment.
If str(...) is called from Python, I assume this doesn't error because of a missing argument (same for other methods)?
| let vios = RefCell::new(None); | ||
|
|
||
| let url = Url::options() | ||
| // if we're in strict mode, we collect consider a syntax violation as an error |
There was a problem hiding this comment.
Suggested change
| // if we're in strict mode, we collect consider a syntax violation as an error | |
| // if we're in strict mode, we collect considering a syntax violation as an error |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
My take on #1719.
I am reasonably confident that the issue only applies to empty paths, so in this variation I named the config option
preserve_empty_path(defaultFalsefor backwards compatibility).Related issue number
pydantic/pydantic#7186
Checklist
pydantic-core(except for expected changes)