Fix combine_by_coords monotonicity check for non-concat dims #10945
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only require monotonic coordinates along concatenation dimensions. Previously, identical non-monotonic coordinates on non-concat dims erroneously raised a ValueError. Includes regression test. Closes # (refer to issue number if applicable)
shoyer
approved these changes
Nov 24, 2025
Member
shoyer
left a comment
shoyer
left a comment
There was a problem hiding this comment.
This looks great, thank you!
Could you please merge in the latest xarray changes from main and verify it still works? Also consider adding a brief note to whats-new.rst.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only require monotonic coordinates along concatenation dimensions. Previously, identical non-monotonic coordinates on non-concat dims erroneously raised a ValueError. Includes regression test.
Closes # (refer to issue number if applicable)
whats-new.rstapi.rst