access.ftp fails to check if files are writable #634
Conversation
|
I just attached a patch to this issue, but for sure it will need to be improved. Is more a quick hack than an actual fix. |
|
normally, all that is taken care of with the "User ID" parameter of the FTP workspace parameters, plus the "Fix Permissions" parameter that can be set to "copy users permissions"... Did you try to tweak those ones before hacking? |
|
Ah, I forgot to mention that I'm using session credentials as FTP login. |
| $credentials = AJXP_Safe::tryLoadingCredentialsFromSources($urlParts, $repository); | ||
| if (empty($credentials["user"])) | ||
| return is_writable($path); | ||
| if ((string)$stat["uid"] == $credentials["user"]) |
There was a problem hiding this comment.
Regarding your comments, this $stat["uid"] is in fact returning a numerical value or here it's can really be the user name?
|
closing, too old, reopen if needed. |
I've found that, to check if a repository file is writable, access.ftp seems to check if web server user can write to that file. But this check is wrong for FTP repositories, it should check if FTP user can write to that file, not web server user.
Thus, delete/rename/etc. buttons are only enabled when files are owned by web server user (www-data or whatever) and not when they belong to FTP user currently logged in.
May it be related to issue #429? I already tried the patch there with no success.