Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: TXT2KG w/ hotpot_qa.py example for precision estimation #9846

Open
wants to merge 154 commits into
base: master
Choose a base branch
from
Open

Draft: TXT2KG w/ hotpot_qa.py example for precision estimation #9846

wants to merge 154 commits into from

Conversation

puririshi98
Copy link
Contributor

rebased #9728

@puririshi98 puririshi98 mentioned this pull request Dec 11, 2024
Closed
@puririshi98 puririshi98 changed the title Draft: TXT2KG w/ hotpot_qa.py` example for precision estimation Draft: TXT2KG w/ hotpot_qa.py example for precision estimation Dec 11, 2024
@puririshi98
Copy link
Contributor Author

@Kh4L reviews welcome

@puririshi98 puririshi98 mentioned this pull request Dec 11, 2024
Merged
@puririshi98 @pre-commit-ci
Improve system prompt for TXT2KG (#9848)
747f0ea 
improve #9846

---------

Co-authored-by: riship <riship@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Kh4L
Kh4L suggested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Kh4L Kh4L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, but LGTM!

torch_geometric/nn/nlp/txt2kg.py Outdated Show resolved Hide resolved
torch_geometric/nn/nlp/txt2kg.py Show resolved Hide resolved
torch_geometric/utils/rag/backend_utils.py Outdated Show resolved Hide resolved
examples/llm/hotpot_qa.py Outdated Show resolved Hide resolved
Kh4L
Kh4L suggested changes Dec 15, 2024
View reviewed changes
torch_geometric/nn/nlp/txt2kg.py Outdated Show resolved Hide resolved
riship and others added 30 commits January 10, 2025 15:06
debug
231e9f4
debug
17933a0
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7db3248 
for more information, see https://pre-commit.ci
debug
7b2d2f6
Merge branch 'rebase-txt2kg' of https://github.com/pyg-team/pytorch_g…
673f8fb 
…eometric into rebase-txt2kg
debug
fc18b59
debug
9a09c98
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
955304e 
for more information, see https://pre-commit.ci
debug
bb6512a
Merge branch 'rebase-txt2kg' of https://github.com/pyg-team/pytorch_g…
976d175 
…eometric into rebase-txt2kg
debug
b6d80b0
debug
eba0173
debug
eeb2a43
debug
954490e
debug
8ac4974
debug
d1c9e13
debug
c3dc6f5
debug
8579159
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2670959 
for more information, see https://pre-commit.ci
debug
961ff44
Merge branch 'rebase-txt2kg' of https://github.com/pyg-team/pytorch_g…
44e676a 
…eometric into rebase-txt2kg
debug
644bcc3
debug
44a17f3
debug
105783c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c8415c1 
for more information, see https://pre-commit.ci
debug
628324d
Merge branch 'rebase-txt2kg' of https://github.com/pyg-team/pytorch_g…
a815db3 
…eometric into rebase-txt2kg
debug
1c75a75
debug
217ec15
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b6aa2c3 
for more information, see https://pre-commit.ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta requested changes

@Kh4L Kh4L Kh4L requested changes

@rusty1s rusty1s Awaiting requested review from rusty1s

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

@mananshah99 mananshah99 Awaiting requested review from mananshah99 mananshah99 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
data dataset example loader nn utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puririshi98 @Kh4L @akihironitta