Fixed bug for writer
initialized by Chem.SDWriter(...)
.
#9929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
writer.close()
statement, the file written bywriter
will not be closed properly. As a result, in our test the end of the file/workspace/data/MoleculeGPT/raw/molecules.sdf
is missing. This is what it looks like:Even the
<PUBCHEM_IUPAC_OPENEYE_NAME
tag does not end correctly with the>
character, and the last molecule (#4303) is missing. As a result, we get a crash later when running the test: