Skip to content

Conversation

eric-wieser
Copy link
Member

Cherry-picked from @meuns' branch (#68)
We can skip a check here, since we know Ga.mv_blades will contain only blades.

No behavior change, but likely a small performance boost.

@eric-wieser eric-wieser added the component: core Ga, Mv, Metric, etc label May 1, 2020
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #275 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   72.74%   72.71%   -0.03%     
==========================================
  Files          11       11              
  Lines        4472     4472              
==========================================
- Hits         3253     3252       -1     
- Misses       1219     1220       +1     
Impacted Files Coverage Δ
galgebra/mv.py 74.30% <100.00%> (ø)
galgebra/ga.py 76.87% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c38568...f407749. Read the comment docs.

@eric-wieser eric-wieser added the ✓ soft CI failure PRs which fail quality but not test CIs label May 1, 2020
@eric-wieser eric-wieser requested a review from utensil May 2, 2020 11:07
@utensil utensil merged commit 2059f87 into pygae:master May 2, 2020
@eric-wieser eric-wieser deleted the upstream-meuns branch May 2, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Ga, Mv, Metric, etc ✓ soft CI failure PRs which fail quality but not test CIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants