-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement occlusion query #544
Conversation
I don't have access to a Windows machine, so I'm not exactly sure what this
is supposed to be and I have no way to test it.
I copied these lines directly from `test_wgpu_native_render.py`.
…On Mon, Jul 29, 2024 at 11:22 AM Korijn van Golen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/test_wgpu_occlusion_query.py
<#544 (comment)>:
> +"""
+Test occlusion queries.
+"""
+
+import numpy as np
+import sys
+
+import wgpu
+from pytest import skip
+from testutils import run_tests, get_default_device
+from testutils import can_use_wgpu_lib, is_ci
+from wgpu import flags
+
+if not can_use_wgpu_lib:
+ skip("Skipping tests that need the wgpu lib", allow_module_level=True)
+elif is_ci and sys.platform == "win32":
Is it possible to make this conditional on DirectX being used? Using
adapter info maybe?
—
Reply to this email directly, view it on GitHub
<#544 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC2LIIVWZNPJIGJQ7KTOODZO2B5BAVCNFSM6AAAAABLUZJDNGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBVGY3TSNBTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@almarklein . You need to approve again. Apparently because there was one unresolved conversation at the time you approved, it didn't count. |
Thank you! We greatly appreciate your contributions. |
By the way, I've also got RenderBundles working, though I haven't yet
written any significant tests. (I have rewritten some vanilla code to use
them, so I know the basic idea is sound.)
Is there some bulletin or forum I should use to announce this? How do I
find out information like "Which Python versions do we support"?
…On Tue, Jul 30, 2024 at 10:30 AM Korijn van Golen ***@***.***> wrote:
Thank you! We greatly appreciate your contributions.
—
Reply to this email directly, view it on GitHub
<#544 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC2LIIZADJ5BEDNMJWD46LZO7EUTAVCNFSM6AAAAABLUZJDNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYHA2TSNBSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Nice! 🚀
There's the release notes where new features are mentioned. There's also https://github.com/pygfx/wgpu-py/discussions but it is not used much, to be honest. Maybe it'd be nice to have a monthly newsletter of sorts 🤔 |
Implementation turned out to be straightforward.