Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement occlusion query #544

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Implement occlusion query #544

merged 3 commits into from
Jul 30, 2024

Conversation

fyellin
Copy link
Contributor

@fyellin fyellin commented Jul 29, 2024

Implementation turned out to be straightforward.

@fyellin fyellin requested a review from Korijn as a code owner July 29, 2024 18:14
@fyellin
Copy link
Contributor Author

fyellin commented Jul 30, 2024 via email

@fyellin
Copy link
Contributor Author

fyellin commented Jul 30, 2024

@almarklein . You need to approve again. Apparently because there was one unresolved conversation at the time you approved, it didn't count.

@Korijn Korijn merged commit b59e452 into pygfx:main Jul 30, 2024
20 checks passed
@Korijn
Copy link
Collaborator

Korijn commented Jul 30, 2024

Thank you! We greatly appreciate your contributions.

@fyellin
Copy link
Contributor Author

fyellin commented Jul 30, 2024 via email

@fyellin fyellin deleted the occlusion-query branch July 31, 2024 02:28
@almarklein
Copy link
Member

By the way, I've also got RenderBundles working,

Nice! 🚀

Is there some bulletin or forum I should use to announce this?

There's the release notes where new features are mentioned.

There's also https://github.com/pygfx/wgpu-py/discussions but it is not used much, to be honest. Maybe it'd be nice to have a monthly newsletter of sorts 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants