-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi_draw_indirect_counter #594
base: main
Are you sure you want to change the base?
Conversation
This code is working now, but it wasn't working an hour ago, and I didn't really do anything to fix it. I want to make sure I understand what's going on before this is merged. But it's rather straightforward code. |
…d up inside a function definition.
The naga bug is back. |
… works when we do the bug_patch, but not otherwise.
Add missing newline
This code is waiting for a new wgpu-native-lib to include: gfx-rs/wgpu-native#432 We pull directly from wpgu-native, so their next update should include the change. I'm not sure how wgpu-native decides which version of wgpu to use. |
Here's an example: gfx-rs/wgpu-native#402 Basically bumping versions in |
I ask because it seems that tag 22.1.0.5 was created on gfx-rs/wgpu-native on Sept 12. Meanwhile I don't see any tags on gfx-rs/wgpu, and the fix was merged into "trunk" on Sept 2. But it doesn't seem to have made it into the build of lib-native. |
That's correct. The latest tag from wgpu-core is 22.1.0. The versioning of wgpu-native is to take the version of wgpu-core and add a fourth number to it. We've had a few releases (22.1.0.x) for bugfixes and changes to how the binary archives are composed. |
I've confirmed that this code works with a patched wgpu. I've tried it out both on emulated GPUs and on real GPUs. I just need to wait for us to catch up. |
Do we have any news as to when there will be a new wgpu-native? This PR needs big foxes there in order to work. |
I see that gfx-rs/wgpu has just released v 23.0.0. Now I just need to wait for wgpu-native to incorporate that, and then for us to incorporate wgpu-native. |
The work has started some time ago: gfx-rs/wgpu-native#441 |
Implementation of the final two functions.
Fix some typos I had previous made.