Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi_draw_indirect_counter #594

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

multi_draw_indirect_counter #594

wants to merge 24 commits into from

Conversation

fyellin
Copy link
Contributor

@fyellin fyellin commented Sep 20, 2024

Implementation of the final two functions.
Fix some typos I had previous made.

@fyellin
Copy link
Contributor Author

fyellin commented Sep 20, 2024

This code is working now, but it wasn't working an hour ago, and I didn't really do anything to fix it. I want to make sure I understand what's going on before this is merged. But it's rather straightforward code.

@fyellin
Copy link
Contributor Author

fyellin commented Sep 20, 2024

The naga bug is back.

@fyellin
Copy link
Contributor Author

fyellin commented Oct 1, 2024

This code is waiting for a new wgpu-native-lib to include:

gfx-rs/wgpu-native#432
gfx-rs/wgpu#6194

We pull directly from wpgu-native, so their next update should include the change. I'm not sure how wgpu-native decides which version of wgpu to use.

@almarklein
Copy link
Member

I'm not sure how wgpu-native decides which version of wgpu to use.

Here's an example: gfx-rs/wgpu-native#402 Basically bumping versions in cargo.toml and then making the necessary changes. It usually updates for each release of wgpu-core.

@fyellin
Copy link
Contributor Author

fyellin commented Oct 1, 2024

@almarklein.

I ask because it seems that tag 22.1.0.5 was created on gfx-rs/wgpu-native on Sept 12.

Meanwhile I don't see any tags on gfx-rs/wgpu, and the fix was merged into "trunk" on Sept 2. But it doesn't seem to have made it into the build of lib-native.

@almarklein
Copy link
Member

That's correct. The latest tag from wgpu-core is 22.1.0. The versioning of wgpu-native is to take the version of wgpu-core and add a fourth number to it. We've had a few releases (22.1.0.x) for bugfixes and changes to how the binary archives are composed.

@fyellin
Copy link
Contributor Author

fyellin commented Oct 10, 2024

I've confirmed that this code works with a patched wgpu. I've tried it out both on emulated GPUs and on real GPUs.

I just need to wait for us to catch up.

@fyellin
Copy link
Contributor Author

fyellin commented Nov 8, 2024

Do we have any news as to when there will be a new wgpu-native? This PR needs big foxes there in order to work.

@fyellin
Copy link
Contributor Author

fyellin commented Nov 8, 2024

I see that gfx-rs/wgpu has just released v 23.0.0. Now I just need to wait for wgpu-native to incorporate that, and then for us to incorporate wgpu-native.

@almarklein
Copy link
Member

The work has started some time ago: gfx-rs/wgpu-native#441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants