Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consolidation #641

Merged
merged 1 commit into from
Nov 7, 2024
Merged

More consolidation #641

merged 1 commit into from
Nov 7, 2024

Conversation

fyellin
Copy link
Contributor

@fyellin fyellin commented Nov 7, 2024

Several wgpu-only features apply both to RenderPassEncoder and ComputePassEncoder. Move some common code to their nearest shared ancestor (BindingCommandsMixin), but make sure that RenderBundleEncoder can't use it.

When ComputePassEncoder gets set_push_constant, it will be a one-line change.

@fyellin fyellin marked this pull request as ready for review November 7, 2024 06:47
@fyellin fyellin requested a review from Korijn as a code owner November 7, 2024 06:47
@Korijn Korijn merged commit 437921d into pygfx:main Nov 7, 2024
20 checks passed
@fyellin fyellin deleted the compute_push_constant branch November 8, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants