Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that override variables can be used for workgroup sizes and array lengths #692

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

fyellin
Copy link
Contributor

@fyellin fyellin commented Mar 20, 2025

Add tests that verify that workgroup sizes can be dynamically modified using override

@fyellin fyellin marked this pull request as ready for review March 20, 2025 18:25
@Korijn
Copy link
Collaborator

Korijn commented Mar 20, 2025

Seems like your commits aren't on this branch?

…overrideable.

This is simply confirming that a new Naga feature actually works.
@fyellin fyellin requested a review from Korijn as a code owner March 20, 2025 20:45
@fyellin
Copy link
Contributor Author

fyellin commented Mar 20, 2025

Sorry. Ruff error that I didn't notice caused the commit to fail. (Pycharm doesn't strip spaces from blank lines in shader code.) All fixed.

Copy link
Member

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test, thanks!

@Korijn Korijn merged commit c6e46a8 into pygfx:main Mar 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants