Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Bump django-crispy-forms from 1.14.0 to 2.1 #72

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2023

Bumps django-crispy-forms from 1.14.0 to 2.1.

Release notes

Sourced from django-crispy-forms's releases.

2.1

What's Changed

  • Added support for Django 5.0.
  • Dropped support for Django 3.2, 4.0 and 4.1.
  • Added support for Python 3.12.
  • Dropped support for Python 3.7.

New Contributors

Full Changelog: django-crispy-forms/django-crispy-forms@2.0...2.1

2.0 (2023-02-13)

Major Changes and Migration Guide

  • Removed all Bootstrap template packs. These template packs are now available as standalone packages. To upgrade, install the required template pack and add it to your INSTALLED_APPS setting.

    Also, support for Bootstrap 5 is provided by a 3rd party package under the django-crispy-forms organisation at crispy-bootstrap5.

  • Removed uni-form template pack. Uni-Form specific classes previously added to every template pack e.g. textInput are now removed. If you require these classes, the previous behaviour can be restored by adding the following to CRISPY_CLASS_CONVERTERS in your settings file.

      converters = {
        "textinput": "textinput textInput",
        "fileinput": "fileinput fileUpload",
        "passwordinput": "textinput textInput",
    }
    
  • The uni-form template pack allowed for rendering of templates using a default or inline layout. As the uni-form template pack has been removed support for this has also been removed. This has resulted in the following BREAKING changes.

    • The form_style attribute of FormHelper is removed.
    • The form_style positional argument to render_field() is removed.
    • The form_style positional argument to the render() method of all LayoutObjects is removed.

    Audit for use of render() and render_field() due to the removal of the form_style positional argument is therefore required. For example:

... (truncated)

Changelog

Sourced from django-crispy-forms's changelog.

2.1 (2023-10-15)

  • Added support for Django 5.0.
  • Dropped support for Django 3.2, 4.0 and 4.1.
  • Added support for Python 3.12.
  • Dropped support for Python 3.7.

See the 2.1 Milestone for the full change list.

2.0 (2023-02-13)

Release of django-crispy-forms 2.0. No changes introduced since 2.0a1.

2.0a1 (2023-01-18)

Major Changes and Migration Guide

  • Removed all Bootstrap template packs. These template packs are now available as standalone packages. To upgrade, install the required template pack and add it to your INSTALLED_APPS setting.

    Also, support for Bootstrap 5 is provided by a 3rd party package under the django-crispy-forms organisation at crispy-bootstrap5.

  • Removed uni-form template pack. Uni-Form specific classes previously added to every template pack e.g. textInput are now removed. If you require these classes, the previous behaviour can be restored by adding the following to CRISPY_CLASS_CONVERTERS in your settings file.

      converters = {
        "textinput": "textinput textInput",
        "fileinput": "fileinput fileUpload",
        "passwordinput": "textinput textInput",
    }
    
  • The uni-form template pack allowed for rendering of templates using a default or inline layout. As the uni-form template pack has been removed support for this has also been removed. This has resulted in the following BREAKING changes.

    • The form_style attribute of FormHelper is removed.
    • The form_style positional argument to render_field() is removed.
    • The form_style positional argument to the render() method of all LayoutObjects is removed.

    Audit for use of render() and render_field() due to the removal of the form_style positional argument is therefore required. For example:

    # django-crispy-forms 1.x
    html = my_layout_object.render(form, form_style, context)
    

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [django-crispy-forms](https://github.com/django-crispy-forms/django-crispy-forms) from 1.14.0 to 2.1.
- [Release notes](https://github.com/django-crispy-forms/django-crispy-forms/releases)
- [Changelog](https://github.com/django-crispy-forms/django-crispy-forms/blob/main/CHANGELOG.md)
- [Commits](django-crispy-forms/django-crispy-forms@1.14.0...2.1)

---
updated-dependencies:
- dependency-name: django-crispy-forms
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 16, 2023
@roskakori
Copy link
Contributor

This seems to fail because we are still using uniforms, which have been removed in django-crispy-forms 2.0. It seems we need to upgrade to bootstrap to keep using them.

For more information, the the django-crispy-form 2.0 release notes and migration hints.

See also for version 2.0: https://github.com/pygraz/website/pull/50#issuecomment-1696949747

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant