Skip to content

Detect arguments as well#164

Open
samwaseda wants to merge 10 commits intomainfrom
args
Open

Detect arguments as well#164
samwaseda wants to merge 10 commits intomainfrom
args

Conversation

@samwaseda
Copy link
Member

@samwaseda samwaseda commented Feb 26, 2026

Following the effort in #155, I started trying to parse variables as well. Edits will follow....

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/flowrep/args

@samwaseda samwaseda changed the base branch from main to crawler February 26, 2026 08:36
@samwaseda samwaseda marked this pull request as draft February 26, 2026 08:37
@samwaseda
Copy link
Member Author

@liamhuber I started looking into the possibility of including variables as well. Frankly I'm also not really convinced but I still would like to explore the possibility

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 64.55696% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.46%. Comparing base (5491049) to head (a646a44).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
flowrep/models/parsers/dependency_parser.py 64.55% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   98.97%   97.46%   -1.51%     
==========================================
  Files          28       28              
  Lines        1949     2015      +66     
==========================================
+ Hits         1929     1964      +35     
- Misses         20       51      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samwaseda
Copy link
Member Author

I just had a discussion with @XzzX and we think we can keep the current implementation is maybe not quite as useless as I had imagined, because with this implementation it is now possible to throw an error as soon as an external variable is used.

@liamhuber
Copy link
Member

because with this implementation it is now possible to throw an error as soon as an external variable is used.

Failing cleanly is infinitely better than looking like everything is well-provenanced when it isn't. However, I still think that restricting "ok locally defined stuff" to mean "don't use any symbols outside your function definition" is going to turn out to be a more annoying, more restrictive, more-work solution than telling people "you'll have to use well-versioned code to contribute to the KG". As an intermediate step towards catching and leveraging these external symbols, this still seems like solid progress though.

Base automatically changed from crawler to main February 27, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants