minor change to region search in sorted_array

janitor/functions/_numba.py

@@ -1219,10 +1219,7 @@ def _numba_non_equi_join_not_monotonic_keep_all(
             _num = np.uint64(num)
             region = right_regions[_num, 0]
             arr = maxxes[:maxxes_counter]
-            posn = _numba_less_than(arr=arr, value=region)
-            # it is larger than the max in the maxxes array
-            # shove it into the last column
-            if posn == -1:
+            if region > maxxes[-1]:
                 posn = maxxes_counter - 1
                 posn_ = np.uint64(posn)
                 len_arr = lengths[posn_]
@@ -1232,6 +1229,7 @@ def _numba_non_equi_join_not_monotonic_keep_all(
                 maxxes[posn_] = region
                 lengths[posn_] += 1
             else:
+                posn = _numba_less_than(arr=arr, value=region)
                 sorted_array, positions_array, lengths, maxxes = (
                     _numba_sorted_array(
                         sorted_array=sorted_array,
@@ -1341,8 +1339,7 @@ def _numba_non_equi_join_not_monotonic_keep_all(
             _num = np.uint64(num)
             region = right_regions[_num, 0]
             arr = maxxes[:maxxes_counter]
-            posn = _numba_less_than(arr=arr, value=region)
-            if posn == -1:
+            if region > maxxes[-1]:
                 posn = maxxes_counter - 1
                 posn_ = np.uint64(posn)
                 len_arr = lengths[posn_]
@@ -1352,6 +1349,7 @@ def _numba_non_equi_join_not_monotonic_keep_all(
                 maxxes[posn_] = region
                 lengths[posn_] += 1
             else:
+                posn = _numba_less_than(arr=arr, value=region)
                 sorted_array, positions_array, lengths, maxxes = (
                     _numba_sorted_array(
                         sorted_array=sorted_array,
@@ -1365,7 +1363,7 @@ def _numba_non_equi_join_not_monotonic_keep_all(
                 )
             r_count += 1
             posn_ = np.uint64(posn)
-            # have we reached the max size of this column?
+            # have we exceeded the size of this column?
             # do we need to trim and move data to other columns?
             check = (lengths[posn_] == (load_factor * 2)) & (
                 r_count < right_index.size
@@ -1487,8 +1485,7 @@ def _numba_non_equi_join_not_monotonic_keep_first(
             _num = np.uint64(num)
             region = right_regions[_num, 0]
             arr = maxxes[:maxxes_counter]
-            posn = _numba_less_than(arr=arr, value=region)
-            if posn == -1:
+            if region > maxxes[-1]:
                 posn = maxxes_counter - 1
                 posn_ = np.uint64(posn)
                 len_arr = lengths[posn_]
@@ -1498,6 +1495,7 @@ def _numba_non_equi_join_not_monotonic_keep_first(
                 maxxes[posn_] = region
                 lengths[posn_] += 1
             else:
+                posn = _numba_less_than(arr=arr, value=region)
                 sorted_array, positions_array, lengths, maxxes = (
                     _numba_sorted_array(
                         sorted_array=sorted_array,
@@ -1654,8 +1652,7 @@ def _numba_non_equi_join_not_monotonic_keep_last(
             _num = np.uint64(num)
             region = right_regions[_num, 0]
             arr = maxxes[:maxxes_counter]
-            posn = _numba_less_than(arr=arr, value=region)
-            if posn == -1:
+            if region > maxxes[-1]:
                 posn = maxxes_counter - 1
                 posn_ = np.uint64(posn)
                 len_arr = lengths[posn_]
@@ -1665,6 +1662,7 @@ def _numba_non_equi_join_not_monotonic_keep_last(
                 maxxes[posn_] = region
                 lengths[posn_] += 1
             else:
+                posn = _numba_less_than(arr=arr, value=region)
                 sorted_array, positions_array, lengths, maxxes = (
                     _numba_sorted_array(
                         sorted_array=sorted_array,