-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pyproject.toml and common workflows #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoubelet
added
Type: Feature
A (suggetion for a) new feature or enhancement in functionality.
Feature
Type: CI/CD
Improvements, updates and fixes to the continuous integration.
labels
Aug 12, 2024
As with other PRs where migration to common workflows was done, I will update the requested passing tests when the PR is accepted. |
Failure status is due to reduced coverage, as no functionality changed but a few (3 I believe) lines of code were removed (unused imports). |
JoschD
reviewed
Aug 13, 2024
JoschD
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: CI/CD
Improvements, updates and fixes to the continuous integration.
Type: Feature
A (suggetion for a) new feature or enhancement in functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long overdue, I am starting the wave of PRs transitioning our packages to using the standard
pyproject.toml
file.Important
The
setup.py
andsetup.cfg
files are gone. Apyproject.toml
file now centralises everything, including metadata conformly to PEP621.I have put down
hatchling
as a build backend, as it is the one developped byPyPA
, the Python Packaging Authority, as they publish the authoritative user guide. This has little impact though, as any PEP518-compliant backend would work there instead.Like for all other packages, this moves the minimum supported Python version to
3.9
.Details
I have put Hatch as a packaging tool as it is also the one from PyPA, but it is strictly optional. One does not need Hatch, because standards. The new common workflows (PR upcoming) don't even use it.
I have taken upon me to remove unused declared dependencies (
hypothesis
,attrs
etc) and sometime up minimum required versions (tfs-pandas
for instance).Additional
This PR also moves
pylhc
to the common Github Actions workflows, and brings very minor lints.