Update attrs brain to exclude ClassVar annotated attributes
#2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
+ Coverage 93.31% 93.35% +0.03%
==========================================
Files 91 91
Lines 11094 11100 +6
==========================================
+ Hits 10352 10362 +10
+ Misses 742 738 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
zenlyj
commented
Sep 2, 2025
DanielNoord
reviewed
Sep 3, 2025
zenlyj
force-pushed
the
update-brain-attrs
branch
3 times, most recently
from
d5421ed to
a768ecd
Compare
DanielNoord
reviewed
Sep 4, 2025
zenlyj
force-pushed
the
update-brain-attrs
branch
from
a768ecd to
a11d343
Compare
DanielNoord
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This is related to pylint #10525. When a class is decorated with
attrs.define, attributes are treated as instance variables, unless they are explicitly annotated withtyping.ClassVar. However, theattrsbrain transforms all class attributes into instance attributes, including those withClassVartype annotation.This update fixes that behavior by ensuring that attributes annotated with
ClassVarare skipped during the transformation.