Fix an issue with empty preallocation #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original logic in `grow_append` was to extend data by 10% of its length. This is a problem with the original data length is 0, since it then never extends. This commit amends `grow_append` to always extend by at least 10 elements.
`grow_append` cannot know if ``preallocate = 0`` was used: it only looks at the `rigid` value to determine how to append. Because of this, will always fail when we use `preallocate = 0` with tensor variables, since then the shapes of `target` and `extension` don’t match. A simple fix is to simply deactivate the special behavior for `preallocate = 0`. - This commit extends `test_growing` with a `preallocate` parameter, so that we test both cases where it is 0 and positive. - We also fix `test_growing` to match the new behavior of `grow_append` introduced in #ea812b0, where data arrays always grow by at least 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original logic of
grow_appendwas to extend data by 10% of its length.This is a problem with the original data length is 0, since it then never extends.
This PR amends
grow_appendto always extend by at least 10 elements.It also updates the
_growingtest to test both 0 and non-zero preallocation.