Skip to content

Conversation

@AAlexxis222
Copy link

Migrates pymc-extras to support ArviZ 1.0, replacing InferenceData with xarray.DataTree.

Changes:

  • Imports: Replaced arviz.InferenceData with xarray.DataTree.
  • Attributes: Refactored .posterior access to dictionary style (["posterior"]).
  • API: Updated constructors (DataTree.from_dict) and replaced .extend() with .update().

Verification:

  • ~325 tests passing (verified against PyMC PR #8019 rebase).
  • Validated prior and pathfinder modules.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In many places you are apllying formating issues. Are you sure these are needed?

@AAlexxis222
Copy link
Author

Hi! Yes, I applied the formatting tools (black, isort, ruff) because the pre-commit CI job was failing with linting errors on the modified files.

I wanted to ensure the CI was green. However, if you prefer to keep the diff minimal, I can try to revert the style changes and only keep the logic migration (though pre-commit might fail again)

@aloctavodia
Copy link
Member

That's fine, just checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants